<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body bgcolor="white" lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> Hi Laine,<o:p></o:p> I verified your fix and it working.<o:p></o:p> Do I need to fill bug for this? <o:p> </o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: sendmail [mailto:justsendmailnothingelse@gmail.com] On Behalf Of Laine Stump Sent: Tuesday, June 16, 2015 6:50 PM To: libvir-list@redhat.com Cc: Moshe Levi Subject: Re: [libvirt] nodedev-dumpxml doesn't refresh supported offload NIC capabilities<o:p></o:p> </div> </div> <o:p> </o:p> <div> On 06/16/2015 10:12 AM, Moshe Levi wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi,<o:p></o:p> <o:p></o:p> I was playing with the nodedev-dumpxml to see the supported offload NIC capabilities, and<o:p></o:p> It seem that if I disable one of offloading capabilities using ethtool command nodedev-dumpxml it still return<o:p></o:p> the feature as enabled. To get the correct offloading capabilities I have to restart libvirtd.<o:p></o:p> I was wandering if that is an expected behavior in lbivirt .<o:p></o:p> </blockquote> the nodedevice driver caches all the information it gets from udev, and tries to rely on udev generating events when something changes. In general this is a bad idea, and has led to at least 2 bug reports I can think of. The function update_caps() in the nodedev driver is intended to be filled in with code to update those attributes of a device that don't get properly updated via udev event responses. It looks like all that would be required in your situation would be to add a call to virNetDevGetFeatures() to the VIR_NODE_DEV_CAP_NET case of the switch in that function. It's complicated a bit by the fact that virNetDevGetFeatures() leaks any existing bitmap of features when it's called. I'm sending a short patch that should fix your problem, which should show up on the list in a few minutes. <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> Please see example below with the rx capabilities disabled. <o:p> </o:p> <o:p></o:p> virsh # nodedev-dumpxml net_enp4s0_f4_52_14_11_73_81<o:p></o:p> <device> <o:p></o:p> <name>net_enp4s0_f4_52_14_11_73_81</name> <o:p></o:p> <path>/sys/devices/pci0000:00/0000:00:02.0/0000:04:00.0/net/enp4s0</path><o:p></o:p> <parent>pci_0000_04_00_0</parent> <o:p></o:p> <capability type='net'> <o:p></o:p> <interface>enp4s0</interface> <o:p></o:p> <address>f4:52:14:11:73:81</address> <o:p></o:p> <link speed='40000' state='up'/> <o:p></o:p> <feature name='rx'/> <o:p></o:p> <feature name='tx'/> <o:p></o:p> <feature name='sg'/> <o:p></o:p> <feature name='tso'/> <o:p></o:p> <feature name='gso'/> <o:p></o:p> <feature name='gro'/> <o:p></o:p> <feature name='rxvlan'/> <o:p></o:p> <feature name='txvlan'/> <o:p></o:p> <feature name='rxhash'/> <o:p></o:p> <capability type='80203'/> <o:p></o:p> </capability> <o:p></o:p> </device> <o:p></o:p> ethtool -K enp4s0 rx off<o:p></o:p> virsh # nodedev-dumpxml net_enp4s0_f4_52_14_11_73_81<o:p></o:p> <device> <o:p></o:p> <name>net_enp4s0_f4_52_14_11_73_81</name> <o:p></o:p> <path>/sys/devices/pci0000:00/0000:00:02.0/0000:04:00.0/net/enp4s0</path><o:p></o:p> <parent>pci_0000_04_00_0</parent> <o:p></o:p> <capability type='net'> <o:p></o:p> <interface>enp4s0</interface> <o:p></o:p> <address>f4:52:14:11:73:81</address> <o:p></o:p> <link speed='40000' state='up'/> <o:p></o:p> <feature name='rx'/> <o:p></o:p> <feature name='tx'/> <o:p></o:p> <feature name='sg'/> <o:p></o:p> <feature name='tso'/> <o:p></o:p> <feature name='gso'/> <o:p></o:p> <feature name='gro'/> <o:p></o:p> <feature name='rxvlan'/> <o:p></o:p> <feature name='txvlan'/> <o:p></o:p> <feature name='rxhash'/> <o:p></o:p> <capability type='80203'/> <o:p></o:p> </capability> <o:p></o:p> </device><o:p></o:p> <o:p></o:p> <o:p></o:p> virsh #<o:p></o:p> [root@r-ae-host05 bin]# ps -ef | grep libvirt<o:p></o:p> root 16743 23086 0 16:43 pts/2 00:00:00 ../sbin/libvirtd<o:p></o:p> root 17440 23086 0 16:47 pts/2 00:00:00 grep --color=auto libvirt<o:p></o:p> [root@r-ae-host05 bin]# kill 16743<o:p></o:p> [root@r-ae-host05 bin]# ../sbin/libvirtd &<o:p></o:p> [2] 17489<o:p></o:p> [1] Done ../sbin/libvirtd<o:p></o:p> [root@r-ae-host05 bin]#<o:p></o:p> [root@r-ae-host05 bin]#<o:p></o:p> [root@r-ae-host05 bin]# ./virsh<o:p></o:p> <o:p></o:p> virsh # nodedev-dumpxml net_enp4s0_f4_52_14_11_73_81<o:p></o:p> <device><o:p></o:p> <name>net_enp4s0_f4_52_14_11_73_81</name><o:p></o:p> <path>/sys/devices/pci0000:00/0000:00:02.0/0000:04:00.0/net/enp4s0</path><o:p></o:p> <parent>pci_0000_04_00_0</parent><o:p></o:p> <capability type='net'><o:p></o:p> <interface>enp4s0</interface><o:p></o:p> <address>f4:52:14:11:73:81</address><o:p></o:p> <link speed='40000' state='up'/><o:p></o:p> <feature name='tx'/><o:p></o:p> <feature name='sg'/><o:p></o:p> <feature name='tso'/><o:p></o:p> <feature name='gso'/><o:p></o:p> <feature name='gro'/><o:p></o:p> <feature name='rxvlan'/><o:p></o:p> <feature name='txvlan'/><o:p></o:p> <feature name='rxhash'/><o:p></o:p> <feature name='rdma'/><o:p></o:p> <capability type='80203'/><o:p></o:p> </capability><o:p></o:p> </device><o:p></o:p> <o:p></o:p> <o:p></o:p> Thanks, <o:p></o:p> Moshe Levi.<o:p></o:p> <o:p></o:p> <o:p></o:p> <pre>--<o:p></o:p></pre> <pre>libvir-list mailing list<o:p></o:p></pre> <pre><a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><o:p></o:p></pre> <pre><a href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a><o:p></o:p></pre> </blockquote> <o:p> </o:p> </div> </body> </html>