<div dir="ltr">Dear Sir, <div>The <a href="http://cfg.mk">cfg.mk</a> link isn't working for me sir..</div><div>From what I understand Makefile will have the following:</div><div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important"><br></code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important">target: dependency1 dependency2 ...</code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important">[TAB] action1</code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important">[TAB] action2</code></div></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important"><br></code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important">Does the syntax-check rule have to be in place of 'actions' in the form of a shell command, and then raise an error whenever the shell command returns occurrences of the string !STREQ or !STRNEQ ? Request you to please elaborate a little. </code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important"><br></code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important"><br></code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;color:rgb(50,50,50);margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><code class="" style="margin:0px!important;padding:0px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;color:black!important;border-radius:0px!important;float:none!important;height:auto!important;line-height:1.1em!important;overflow:visible!important;width:auto!important;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace!important;min-height:auto!important;background:none!important">Sincerely,</code></div><div class="" style="font-size:12px;line-height:13.1999998092651px;font-family:Consolas,'Bitstream Vera Sans Mono','Courier New',Courier,monospace;margin:0px!important;padding:0px 1em 0px 3px!important;border:0px!important;outline:0px!important;vertical-align:baseline!important;border-radius:0px!important;float:none!important;height:auto!important;overflow:visible!important;width:auto!important;min-height:auto!important;white-space:pre!important;background-image:none!important;background-repeat:initial!important"><font color="#000000">Lasya V </font></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 21 September 2015 at 16:35, Michal Privoznik <span dir="ltr"><<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">[You've got the wrong list. This is a libvirt patch and as such it<br>
should have been sent to the <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>]<br>
<div><div class="h5"><br>
On 19.09.2015 16:59, Lasya wrote:<br>
> Hi,<br>
> This is my first patch in QEMU. I have solved a bite-sized bug. I have updated the !STREQ with STRNEQ in the following files. Thanks.<br>
><br>
> ---<br>
> src/bhyve/bhyve_driver.c | 2 +-<br>
> src/conf/network_conf.c | 4 ++--<br>
> src/conf/nwfilter_conf.c | 2 +-<br>
> src/conf/nwfilter_params.c | 2 +-<br>
> src/conf/storage_conf.c | 2 +-<br>
> src/lxc/lxc_fuse.c | 4 ++--<br>
> src/openvz/openvz_driver.c | 2 +-<br>
> src/qemu/qemu_command.c | 6 +++---<br>
> src/qemu/qemu_domain.c | 2 +-<br>
> src/qemu/qemu_hotplug.c | 2 +-<br>
> src/security/security_manager.c | 2 +-<br>
> src/security/security_selinux.c | 12 ++++++------<br>
> src/storage/storage_backend_logical.c | 2 +-<br>
> src/util/virfile.c | 2 +-<br>
> src/util/virsystemd.c | 2 +-<br>
> src/vz/vz_driver.c | 2 +-<br>
> src/vz/vz_sdk.c | 2 +-<br>
> src/xen/xend_internal.c | 2 +-<br>
> src/xenconfig/xen_sxpr.c | 2 +-<br>
> tests/commandtest.c | 10 +++++-----<br>
> tests/securityselinuxlabeltest.c | 2 +-<br>
> tests/virauthconfigtest.c | 2 +-<br>
> tests/virbitmaptest.c | 12 ++++++------<br>
> tests/vircgrouptest.c | 2 +-<br>
> tests/virkeyfiletest.c | 8 ++++----<br>
> tests/virnetsockettest.c | 2 +-<br>
> tests/virtypedparamtest.c | 2 +-<br>
> tests/viruritest.c | 16 ++++++++--------<br>
> 28 files changed, 56 insertions(+), 56 deletions(-)<br>
<br>
</div></div>Okay, you've got all the occurrences. However, the syntax-check rule is<br>
missing. You may want to look at <a href="http://cfg.mk" rel="noreferrer" target="_blank">cfg.mk</a> for some examples. syntax-check<br>
is our make target that checks the code if it complies with our coding<br>
standards. After this patch we want a rule that forbids !STREQ or !STRNEQ.<br>
<br>
Otherwise looking very good. Looking forward to v2.<br>
<span class="HOEnZb"><font color="#888888"><br>
Michal<br>
</font></span></blockquote></div><br></div>