<div dir="ltr">Please drop this patch. I sent it too early. I think the existing migration behavior with --persistent is expected.<div><br></div><div>Thanks,</div><div>Shiva </div><div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 26, 2016 at 1:31 PM, Shivaprasad G Bhat <span dir="ltr"><<a href="mailto:shivaprasadbhat@gmail.com" target="_blank">shivaprasadbhat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The migration would fail if the checks in virDomainDefPostParseMemory() fail<br>
after ABI update. The ABI update normally done during the guest start and not<br>
during define. If someone is using --persistent with the virsh<br>
migrate it should be treated equivalent to domain define and not start. The<br>
furture restart would/should anyway do the ABI updates and flag correct errors.<br>
<br>
Signed-off-by: Shivaprasad G Bhat <<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a>><br>
---<br>
src/qemu/qemu_migration.c | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c<br>
index 51e7125..39e259a 100644<br>
--- a/src/qemu/qemu_migration.c<br>
+++ b/src/qemu/qemu_migration.c<br>
@@ -1284,8 +1284,7 @@ qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,<br>
}<br>
mig->persistent = virDomainDefParseNode(doc, nodes[0],<br>
caps, driver->xmlopt,<br>
- VIR_DOMAIN_DEF_PARSE_INACTIVE |<br>
- VIR_DOMAIN_DEF_PARSE_ABI_UPDATE);<br>
+ VIR_DOMAIN_DEF_PARSE_INACTIVE);<br>
if (!mig->persistent) {<br>
/* virDomainDefParseNode already reported<br>
* an error for us */<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a><br>
</blockquote></div><br></div>