<div dir="ltr"><div><div><div>Hello All,<br><br></div>Any comments on this small patch?<br><br></div>Warm Regards,<br></div>Nitesh Konkar.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 3, 2016 at 4:38 PM, Nitesh Konkar <span dir="ltr"><<a href="mailto:niteshkonkar.libvirt@gmail.com" target="_blank">niteshkonkar.libvirt@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
 src/libvirt-domain.c | 27 +++++++++++++++++++++++++++<br>
 1 file changed, 27 insertions(+)<br>
<br>
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c<br>
index 9491845..dc11945 100644<br>
--- a/src/libvirt-domain.c<br>
+++ b/src/libvirt-domain.c<br>
@@ -3617,6 +3617,15 @@ virDomainMigrate(virDomainPtr domain,<br>
                              error);<br>
<br>
+    if (flags & VIR_MIGRATE_OFFLINE) {<br>
+        if (flags & VIR_MIGRATE_LIVE) {<br>
+            virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",<br>
+                           _("Live and offline migration flags are "<br>
+                             "mutually exclusive"));<br>
+            goto error;<br>
+        }<br>
+    }<br>
+<br>
     if (flags & VIR_MIGRATE_OFFLINE) {<br>
         if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,<br>
                                       VIR_DRV_FEATURE_MIGRATION_OFFLINE)) {<br>
             virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",<br>
@@ -3841,6 +3850,15 @@ virDomainMigrate2(virDomainPtr domain,<br>
                              error);<br>
<br>
+    if (flags & VIR_MIGRATE_OFFLINE) {<br>
+        if (flags & VIR_MIGRATE_LIVE) {<br>
+            virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",<br>
+                           _("Live and offline migration flags are "<br>
+                             "mutually exclusive"));<br>
+            goto error;<br>
+        }<br>
+    }<br>
+<br>
     if (flags & VIR_MIGRATE_OFFLINE) {<br>
         if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,<br>
                                       VIR_DRV_FEATURE_MIGRATION_OFFLINE)) {<br>
             virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",<br>
@@ -4014,6 +4032,15 @@ virDomainMigrate3(virDomainPtr domain,<br>
                              VIR_MIGRATE_NON_SHARED_INC,<br>
                              error);<br>
<br>
+    if (flags & VIR_MIGRATE_OFFLINE) {<br>
+        if (flags & VIR_MIGRATE_LIVE) {<br>
+            virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",<br>
+                           _("Live and offline migration flags are "<br>
+                             "mutually exclusive"));<br>
+            goto error;<br>
+        }<br>
+    }<br>
+<br>
     if (flags & VIR_MIGRATE_PEER2PEER) {<br>
         virReportInvalidArg(flags, "%s",<br>
                             _("use virDomainMigrateToURI3 for peer-to-peer "<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.1<br>
<br>
</font></span></blockquote></div><br></div>