<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 03/31/2016 11:58 AM, Moshe Levi wrote: </div> <blockquote cite="mid:AM4PR05MB182670E898457A69D8289C83D0990@AM4PR05MB1826.eurprd05.prod.outlook.com" type="cite"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> <div class="WordSection1"> Thanks Laine,<o:p></o:p> <o:p> </o:p> Adding the driver_name o the config did the trick, thanks J <o:p></o:p> <o:p> </o:p> Regarding the vifo error it seem that openstack does roleback if operation failed so that why you see the virDomainAttachDeviceFlags<o:p></o:p> Anyhow I found that the in qemu 2.1 suspend is not working (I got error [1] ) so I upgrade to qemu 2.5 and then suspend work but it failed on resume. <o:p></o:p> <o:p> </o:p> So Just to clarify vfio is not supporting “attach device” right? is qemu going to support it? </div> </blockquote> Not at all. attach device works just fine with vfio (that's how hotplug is done). I've just been using it myself in some testing. (note that vfio has been supported since kernel 3.6 and libvirt 1.0.5, i.e. a "very long time") <blockquote cite="mid:AM4PR05MB182670E898457A69D8289C83D0990@AM4PR05MB1826.eurprd05.prod.outlook.com" type="cite"> <div class="WordSection1"> <o:p></o:p> Now I wonder if I need to hardcode in the hostdev config to be with driver_name=kvm… </div> </blockquote> I certainly hope not. You would be viciously attacked by the keeper of vfio for your transgression! :-) Seriously, there should be no reason whatsoever to force driver name='kvm'. This was made configurable *only* as a fallback in case errors were encountered with vfio during its early days. As a matter of fact, I'm pretty sure that RHEL7 has legacy kvm device assignment completely disabled. If you are needing to force legacy kvm device assignment to make your setup work, then there is a bug somewhere that needs to be investigated and squashed. <blockquote cite="mid:AM4PR05MB182670E898457A69D8289C83D0990@AM4PR05MB1826.eurprd05.prod.outlook.com" type="cite"> <div class="WordSection1"> <o:p></o:p> <o:p> </o:p> <o:p> </o:p> [1] -ERROR:qom/object.c:725:object_unref: assertion failed: (obj->ref > 0)<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: sendmail [<a class="moz-txt-link-freetext" href="mailto:justsendmailnothingelse@gmail.com">mailto:justsendmailnothingelse@gmail.com</a>] On Behalf Of Laine Stump Sent: Wednesday, March 30, 2016 9:25 PM To: Libvirt <a class="moz-txt-link-rfc2396E" href="mailto:libvir-list@redhat.com"><libvir-list@redhat.com></a> Cc: Moshe Levi <a class="moz-txt-link-rfc2396E" href="mailto:moshele@mellanox.com"><moshele@mellanox.com></a> Subject: Re: [libvirt] Host device assignment driver name vfio/ kvm<o:p></o:p> </div> </div> <o:p> </o:p> <div> On 03/29/2016 07:45 AM, Moshe Levi wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi,<o:p></o:p> <o:p></o:p> I was testing <a moz-do-not-send="true" name="elementsHostDev">Host device assignment</a> in OpenStack environment where the driver name is vfio or kvm. <o:p></o:p> <o:p></o:p> My setup is as follow: <o:p></o:p> 1. Fedora 21<o:p></o:p> 2. Libvirt 1.3.0 which I compiled<o:p></o:p> 3. OpenStack master <o:p></o:p> <o:p></o:p> I have also other setups with older Libvirt version and the same OpenStack environment. <o:p></o:p> <o:p></o:p> I notice that on my fedora environment the driver name is vfio were in my old environment the driver name is kvm.<o:p></o:p> <o:p></o:p> According to Libvirt documentation default is "vfio" on systems where the VFIO driver is available and loaded, see [1]<o:p></o:p> I remove the vfio modules by removing vfio, vfio_iommu_type1, vfio_pci but when I boot a vm the drive name is vfio<o:p></o:p> How can change the driver name to be kvm?<o:p></o:p> </blockquote> libvirt tries very hard to use vfio rather than legacy kvm, because legacy kvm is old, deprecated, and "declared bad" :-). But it won't changed it to vfio if you've explicitly said that you want to use kvm. If you really want to use legacy kvm device assignment, manually set that in the config. When you do that, if the system you're running on doesn't support it, it will error out rather than switching.<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> Another thing that I encounter is an error when suspending VM (in OpenStack environment) when the driver name is vfio.<o:p></o:p> In such case I am getting the following error from Libvirt:<o:p></o:p> 2016-03-28 11:42:59.527 1966 ERROR oslo_messaging.rpc.dispatcher File "/usr/lib64/python2.7/site-packages/libvirt.py", line 560, in attachDeviceFlags<o:p></o:p> 2016-03-28 11:42:59.527 1966 ERROR oslo_messaging.rpc.dispatcher if ret == -1: raise libvirtError ('virDomainAttachDeviceFlags() failed', dom=self)<o:p></o:p> 2016-03-28 11:42:59.527 1966 ERROR oslo_messaging.rpc.dispatcher libvirtError: internal error: unable to execute QEMU command 'device_add': Device initialization failed.<o:p></o:p> <o:p></o:p> I would appreciate for some pointers on what can cause this issue.<o:p></o:p> </blockquote> Assuming that openstack uses libvirt's virDomainSave API I would expect suspending a guest to fail if it had an assigned device (since libvirt implements this by "migrating to disk", and qemu doesn't allow migration of a guest with an assigned device. But your problem is that it's trying to *attach* a device, which I wouldn't consider to be a part of a save or suspend or whatever operation. Is it possible to get more information about what leads up to this? <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> [1] <a moz-do-not-send="true" href="https://libvirt.org/formatdomain.html#elementsHostDev"> https://libvirt.org/formatdomain.html#elementsHostDev</a><o:p></o:p> <o:p></o:p> <o:p></o:p> <o:p></o:p> <o:p></o:p> <pre>--<o:p></o:p></pre> <pre>libvir-list mailing list<o:p></o:p></pre> <pre><a moz-do-not-send="true" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><o:p></o:p></pre> <pre><a moz-do-not-send="true" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a><o:p></o:p></pre> </blockquote> <o:p> </o:p> </div> </div> </blockquote> </body> </html>