<div dir="ltr">Any comments on this small patch? :-)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 7, 2016 at 2:39 PM, Nitesh Konkar <span dir="ltr"><<a href="mailto:niteshkonkar.libvirt@gmail.com" target="_blank">niteshkonkar.libvirt@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">HBA will get treated as vHBA if not returned<br>
after detecting vhba_parent format.<br>
<br>
Signed-off-by: Nitesh Konkar <<a href="mailto:nitkon12@linux.vnet.ibm.com">nitkon12@linux.vnet.ibm.com</a>><br>
---<br>
Before Patch:<br>
# virsh pool-destroy poolhba_name<br>
error: Failed to destroy pool poolhba_name<br>
error: internal error: Invalid adapter name 'pci_000x_0x_00_x' for SCSI pool<br>
<br>
# virsh nodedev-dumpxml scsi_host2<br>
<device><br>
<name>scsi_host2</name><br>
<path>xxxx</path><br>
<parent>pci_000x_0x_00_x</parent><br>
<capability type='scsi_host'><br>
<host>2</host><br>
...<br>
...<br>
<capability type='vport_ops'><br>
<max_vports>255</max_vports><br>
<vports>0</vports><br>
</capability><br>
</capability><br>
</device><br>
<br>
After Patch:<br>
# virsh pool-destroy poolhba_name<br>
Pool poolhba_name destroyed<br>
<br>
src/storage/storage_backend_scsi.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c<br>
index e6c8bb5..dd0343f 100644<br>
--- a/src/storage/storage_backend_scsi.c<br>
+++ b/src/storage/storage_backend_scsi.c<br>
@@ -842,6 +842,11 @@ deleteVport(virConnectPtr conn,<br>
if (!(vhba_parent = virStoragePoolGetVhbaSCSIHostParent(conn, name)))<br>
goto cleanup;<br>
<br>
+ if (STRPREFIX(vhba_parent, "pci")) {<br>
+ ret = 0;<br>
+ goto cleanup;<br>
+ }<br>
+<br>
if (virGetSCSIHostNumber(vhba_parent, &parent_host) < 0)<br>
goto cleanup;<br>
}<br>
--<br>
1.8.3.1<br>
<br>
</div></div></blockquote></div><br></div>