<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/24/2016 03:55 PM, Laine Stump
wrote:<br>
</div>
<blockquote
cite="mid:e6a9a80c-adca-32d6-941a-eb195d32d3c8@laine.org"
type="cite">
<blockquote type="cite" style="font-weight: bold; color: #660000;">
<blockquote type="cite" style="font-weight: bold; color:
#660000;"> + VIR_DEBUG("Adding IP address %s/%d%s%s%s%s to
%s", ipStr, prefix,
<br>
+ peerStr ? " peer " : "", peerStr ? peerStr :
"",
<br>
+ bcastStr ? " bcast " : "", bcastStr ? bcastStr
: "",
<br>
+ ifname);
<br>
+
<br>
</blockquote>
NULLSTR() or perhaps EMPTYSTR()? For ipStr, peerStr, and
bcastStr...
<br>
<br>
In any case, since ipStr could be NULL it needs the similar
check
<br>
</blockquote>
<br>
Yep. I'll do that.
<br>
</blockquote>
<p><br>
</p>
<p><tt>Actually, neither NULLSTR() nor EMPTYSTR() does what is
needed, as the former inserts "<null>" and the latter
inserts "-", while I want it to insert "". I will do it for
ipStr though, just on the off chance that virSocketAddrFormat()
gets an OOM or some other strange error. (Practically speaking
glibc would put "(null)" into the string in that case, but just
in case someone isn't using glibc...)<br>
</tt></p>
</body>
</html>