<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"></div>An unexpected behavior in systemd has been introduced between the
versions 225 and 229: when non-existing units are specified in
After/Before clauses, systemd fails if the After clause is listed
first. What is expected is that systemd simply ignores these
clauses. Because the After clause is specified before the Before
clause in virSystemdCreateMachine and because libvirt does not
tolerate missing the systemd-machined registration, it leads to
fatal boot failures, whereas instances could start properly without
these units - only the shutdown workflow could be affected.<br><font color="#0a51a1"><br></font>This fixes the following error in some particular cases:
`libvirtError: Cannot set property Before, or unknown
property.`.<br>If accepted, this bug fix should be backported.<br><font color="#0a51a1"><br></font><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1350909">https://bugzilla.redhat.com/show_bug.cgi?id=1350909</a><br>---<br> src/util/virsystemd.c | 8 ++++----<br> 1 file changed, 4 insertions(+), 4 deletions(-)<br><font color="#0a51a1"><br></font>diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c<br>index 871db7e..3a146f8 100644<br>--- a/src/util/virsystemd.c<br>+++ b/src/util/virsystemd.c<br>@@ -365,8 +365,8 @@ int virSystemdCreateMachine(const char
*name,<br> nnicindexes,
nicindexes,<br> 3,<br> "Slice", "s",
slicename,<br>-
"After", "as", 1,
"libvirtd.service",<br>-
"Before", "as", 1,
"libvirt-guests.service") < 0)<br>+
"Before", "as", 1,
"libvirt-guests.service",<br>+
"After", "as", 1,
"libvirtd.service") < 0)<br> goto cleanup;<br><font color="#0a51a1"><br></font> if (error.level == VIR_ERR_ERROR)
{<br>@@ -406,8 +406,8 @@ int virSystemdCreateMachine(const char
*name,<br> rootdir ? rootdir :
"",<br> 3,<br> "Slice", "s",
slicename,<br>-
"After", "as", 1,
"libvirtd.service",<br>-
"Before", "as", 1,
"libvirt-guests.service") < 0)<br>+
"Before", "as", 1,
"libvirt-guests.service",<br>+
"After", "as", 1,
"libvirtd.service") < 0)<br> goto cleanup;<br> }<br><font color="#0a51a1"><br></font>--<br><span><div style="word-wrap:break-word"><div>
<div style="word-wrap:break-word">
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<div id="bloop_customfont" style="margin:0px">
<div id="bloop_customfont" style="margin:0px">
<span>1.8.3.1</span></div>
</div>
</div>
</div>
</div></div></span></body></html>