<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 15/07/16 11:37, Martin Kletzander
wrote:<br>
</div>
<blockquote cite="mid:20160715083724.GB4918@wheatley" type="cite">On
Fri, Jul 15, 2016 at 09:41:11AM +0200, Ján Tomko wrote:
<br>
<blockquote type="cite">On Thu, Jul 14, 2016 at 02:27:40PM +0200,
Martin Kletzander wrote:
<br>
<blockquote type="cite">When reinitializing Ploop volumes we
also went through the rutine of the
<br>
normal wipe, effectively removing the root.hds file twice.
<br>
</blockquote>
<br>
The file was wiped with the selected algorithm first (without
deletion),
<br>
then reinitialized to make sure you can delete it via libvirt
later.
<br>
<br>
</blockquote>
<br>
You're right, I missed that what I was describing only happened
with
<br>
VIR_STORAGE_VOL_WIPE_ALG_ZERO. Anyway since the description for
<br>
vol-wipe is:
<br>
<br>
"Ensure data previously on a volume is not accessible to future
reads"
<br>
<br>
wiping algorithm does not really make sense for file-based
storage.
<br>
That's kind of the whole point of this series.
<br>
</blockquote>
Actually, virStorageBackendVolWipePloop only deletes root.hds and
DiscDescriptor.xml.<br>
So the data on block device can still be accessible. <br>
To prevent this we used little path/to/volume manipulation and wiped
root.hds firstly and<br>
only then called virStorageBackendVolWipePloop. It is incorrect to
call only this function<br>
for ploop. <br>
<blockquote cite="mid:20160715083724.GB4918@wheatley" type="cite">
<br>
<blockquote type="cite">We could get rid of the reinitialization
if we make sure libvirt can
<br>
operate on the volume (after wiping, pretty much only delete
makes
<br>
sense), but removing the actual wiping is wrong.
<br>
<br>
Jan
<br>
<br>
<br>
<blockquote type="cite">Since we'll
<br>
hopefully add support for other formats as well, split the
function with
<br>
a switch into which we can cleanly add formats in the future.
<br>
<br>
Signed-off-by: Martin Kletzander <a class="moz-txt-link-rfc2396E" href="mailto:mkletzan@redhat.com"><mkletzan@redhat.com></a>
<br>
---
<br>
src/storage/storage_backend.c | 49
++++++++++++++++++++++++-------------------
<br>
1 file changed, 27 insertions(+), 22 deletions(-)
<br>
</blockquote>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">--
libvir-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre>
</blockquote>
<p><br>
</p>
</body>
</html>