<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">[...]
</blockquote>
<br></div></div>
Indentation is off here.</blockquote><div>Thank you for noticing that. Indeed, 4 spaces are missing.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-"><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
+            goto cleanup;<br>
+        break;<br>
+    case VIR_DOMAIN_AFFECT_CONFIG:<br>
+        if (virAsprintf(&result_filename,<br>
+                    "%s/qemuhotplugtestdomains/qemuhotplug-%s+%s+config.xml",<br>
+                    abs_srcdir, test->domain_filename,<br>
+                    test->device_filename) < 0)<br>
+            goto cleanup;<br>
+        break;<br>
+    default:<br>
</blockquote>
<br></span>
No need to do default in case the switch condition is an enum, although<br>
I'm not sure how that works with flags (non-continuous values).</blockquote><div>You are right. It will make more sense when I change these enums to flags.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-"><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
+        VIR_TEST_VERBOSE("target can either be VIR_DOMAIN_AFFECT_LIVE"<br>
+                         " or VIR_DOMAIN_AFFECT_CONFIG\n");<br>
</blockquote>
<br></span>
We should also take into account the fact that it can be both, but<br>
should not be _CURRENT in tests.  That way we don't have to do two lines<br>
of DO_TEST_ATTACH_.  Although that might cause confusion with the 'keep'<br>
parameter.<br></blockquote><div>I just wanted to make sure that both *_LIVE and *_CONFIG aren't supplied</div><div>at once, because handling them both isn't implemented yet.</div><div><br></div><div>Tomasz</div></div></div></div>