<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 2:15 PM, Michal Privoznik <span dir="ltr"><<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 08.08.2016 03:53, <a href="mailto:kai.7.kang@gmail.com">kai.7.kang@gmail.com</a> wrote:<br>
> From: Kai Kang <<a href="mailto:kai.kang@windriver.com">kai.kang@windriver.com</a>><br>
><br>
> When build for architecture that don't use gcc atomic ops but pthread,<br>
> it fails to build for armel:<br>
><br>
> | ../tools/nss/.libs/libnss_<wbr>libvirt_impl.a(libvirt_nss_la-<wbr>virobject.o): In function `virClassNew':<br>
> | /buildarea2/kkang/builds/<wbr>qemuarm-Aug03/bitbake_build/<wbr>tmp/work/armv5e-wrs-linux-<wbr>gnueabi/libvirt/1.3.5-r0/<wbr>build/src/../../libvirt-1.3.5/<wbr>src/util/virobject.c:153: undefined reference to `virAtomicLock'<br>
> | ../tools/nss/.libs/libnss_<wbr>libvirt_impl.a(libvirt_nss_la-<wbr>virobject.o): In function `virObjectNew':<br>
> | /buildarea2/kkang/builds/<wbr>qemuarm-Aug03/bitbake_build/<wbr>tmp/work/armv5e-wrs-linux-<wbr>gnueabi/libvirt/1.3.5-r0/<wbr>build/src/../../libvirt-1.3.5/<wbr>src/util/virobject.c:205: undefined reference to `virAtomicLock'<br>
> | ../tools/nss/.libs/libnss_<wbr>libvirt_impl.a(libvirt_nss_la-<wbr>virobject.o): In function `virObjectUnref':<br>
> | /buildarea2/kkang/builds/<wbr>qemuarm-Aug03/bitbake_build/<wbr>tmp/work/armv5e-wrs-linux-<wbr>gnueabi/libvirt/1.3.5-r0/<wbr>build/src/../../libvirt-1.3.5/<wbr>src/util/virobject.c:277: undefined reference to `virAtomicLock'<br>
> | ../tools/nss/.libs/libnss_<wbr>libvirt_impl.a(libvirt_nss_la-<wbr>virobject.o): In function `virObjectRef':<br>
> | /buildarea2/kkang/builds/<wbr>qemuarm-Aug03/bitbake_build/<wbr>tmp/work/armv5e-wrs-linux-<wbr>gnueabi/libvirt/1.3.5-r0/<wbr>build/src/../../libvirt-1.3.5/<wbr>src/util/virobject.c:298: undefined reference to `virAtomicLock'<br>
> | collect2: error: ld returned 1 exit status<br>
><br>
> It is similar with:<br>
><br>
> <a href="http://libvirt.org/git/?p=libvirt.git;a=commit;h=12dc729" rel="noreferrer" target="_blank">http://libvirt.org/git/?p=<wbr>libvirt.git;a=commit;h=12dc729</a><br>
><br>
> Signed-off-by: Kai Kang <<a href="mailto:kai.kang@windriver.com">kai.kang@windriver.com</a>><br>
> ---<br>
>  src/Makefile.am | 2 ++<br>
>  1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/src/Makefile.am b/src/Makefile.am<br>
> index 12b66c2..6e55972 100644<br>
> --- a/src/Makefile.am<br>
> +++ b/src/Makefile.am<br>
> @@ -2989,6 +2989,8 @@ noinst_LTLIBRARIES += <a href="http://libvirt-nss.la" rel="noreferrer" target="_blank">libvirt-nss.la</a><br>
>  libvirt_nss_la_SOURCES =             \<br>
>               util/viralloc.c                 \<br>
>               util/viralloc.h                 \<br>
> +             util/viratomic.c                \<br>
> +             util/viratomic.h                \<br>
>               util/virbitmap.c                \<br>
>               util/virbitmap.h                \<br>
>               util/virbuffer.c                \<br>
><br>
<br>
</div></div>ACKed and pushed. Congratulations on your first libvirt contribution.<br>
<br></blockquote><div><br></div><div>Thanks. :)</div><div><br></div><div>--Kai</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
And it's nice to see people using feature I wrote. I often think how<br>
many users does this plugin has. I know, I know - compiling is not<br>
using, but still :)<br>
<span class="HOEnZb"><font color="#888888"><br>
Michal<br>
</font></span></blockquote></div><br></div></div>