<div dir="ltr">I realized after sending the patch that the code I mentioned as "dead code" is not a dead code. I have sent a v2 for the same. <br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 28, 2016 at 3:19 PM, Nitesh Konkar <span dir="ltr"><<a href="mailto:niteshkonkar.libvirt@gmail.com" target="_blank">niteshkonkar.libvirt@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Currently, the code to display enabled/disabled message is<br>
a dead code as its misplaced in if block instead of else.<br>
This patch fixes that issue.<br>
<br>
Signed-off-by: Nitesh Konkar <<a href="mailto:nitkon12@linux.vnet.ibm.com">nitkon12@linux.vnet.ibm.com</a>><br>
---<br>
tools/virsh-domain.c | 17 +++++++++--------<br>
1 file changed, 9 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c<br>
index 3a6fa5c..624a36a 100644<br>
--- a/tools/virsh-domain.c<br>
+++ b/tools/virsh-domain.c<br>
@@ -8891,18 +8891,19 @@ cmdPerf(vshControl *ctl, const vshCmd *cmd)<br>
vshError(ctl, "%s", _("Unable to get perf events"));<br>
goto cleanup;<br>
}<br>
- for (i = 0; i < nparams; i++) {<br>
- if (params[i].type == VIR_TYPED_PARAM_BOOLEAN &&<br>
- params[i].value.b) {<br>
- vshPrint(ctl, "%-15s: %s\n", params[i].field, _("enabled"));<br>
- } else {<br>
- vshPrint(ctl, "%-15s: %s\n", params[i].field, _("disabled"));<br>
- }<br>
- }<br>
} else {<br>
if (virDomainSetPerfEvents(dom, params, nparams, flags) != 0) {<br>
vshError(ctl, "%s", _("Unable to enable/disable perf events"));<br>
goto cleanup;<br>
+ } else {<br>
+ for (i = 0; i < nparams; i++) {<br>
+ if (params[i].type == VIR_TYPED_PARAM_BOOLEAN &&<br>
+ params[i].value.b) {<br>
+ vshPrint(ctl, "%-15s: %s\n", params[i].field, _("enabled"));<br>
+ } else {<br>
+ vshPrint(ctl, "%-15s: %s\n", params[i].field, _("disabled"));<br>
+ }<br>
+ }<br>
}<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.9.3<br>
<br>
</font></span></blockquote></div><br></div>