<div dir="ltr"><div>Hi Daniel,<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote:<br>
<br>
> @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(<wbr>virDomainPtr dom,<br>
>      if (def) {<br>
>          for (i = 0; i < nparams; i++) {<br>
>              virTypedParameterPtr param = &params[i];<br>
> -            enabled = param->value.b;<br>
> +            state = param->value.i;<br>
<br>
</span>NACK, this semantic change is not backwards compatible - this will break<br>
all applications & language bindings currently using libvirt perf events.<br>
<br></blockquote><div>Oh I see . I didn't realize that. Any other API/place you suggest, through which<br>we can get this functionality in?<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In addition "reset" is not really a state - "enabled" / "disabled" are<br>
stats - 'reset' is an action that is applied to an existing state. So<br>
modelling 'reset' as a state is wrong too IMHO.<br>
<br>
Regards,<br>
Daniel<br></blockquote><div>Thanks,<br></div><div>Nitesh. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">--<br>
|: <a href="http://berrange.com" rel="noreferrer" target="_blank">http://berrange.com</a>      -o-    <a href="http://www.flickr.com/photos/dberrange/" rel="noreferrer" target="_blank">http://www.flickr.com/photos/<wbr>dberrange/</a> :|<br>
|: <a href="http://libvirt.org" rel="noreferrer" target="_blank">http://libvirt.org</a>              -o-             <a href="http://virt-manager.org" rel="noreferrer" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://entangle-photo.org" rel="noreferrer" target="_blank">http://entangle-photo.org</a>       -o-    <a href="http://search.cpan.org/~danberr/" rel="noreferrer" target="_blank">http://search.cpan.org/~<wbr>danberr/</a> :|<br>
</font></span></blockquote></div><br></div></div>