<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote:<br>
> On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote:<br>
> > Signed-off-by: Nitesh Konkar <<a href="mailto:nitkon12@linux.vnet.ibm.com">nitkon12@linux.vnet.ibm.com</a>><br>
> > ---<br>
> >  connect.go      | 54 ++++++++++++++++++++++++++++++<wbr>++++++++++++++++++++++++<br>
> >  domain.go       | 54 ++++++++++++++++++++++++++++++<wbr>++++++++++++++++++++++++<br>
> >  domain_compat.h | 36 ++++++++++++++++++++++++++++++<wbr>++++++<br>
> >  3 files changed, 144 insertions(+)<br>
><br>
> The files are improperly indented. The go files use tabs for indentation<br>
> while your code uses spaces. I've already pointed this out in v1.<br>
<br>
</span>More specifically the go files use 'gofmt' for formatting. The best way<br>
to achieve this is to setup your editor to automatically run gofmt when<br>
saving files. If you are using emacs this is achieved by installing and<br>
using this lisp file<br></blockquote><div>Thanks Daniel. However I am using vim and I think<br>gofmt -w domain.go and gofmt -w connect.go would help me<br></div><div>achieve the same.<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  <a href="https://github.com/dominikh/go-mode.el" rel="noreferrer" target="_blank">https://github.com/dominikh/<wbr>go-mode.el</a><br>
<br>
Regards,<br>
Daniel<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
|: <a href="http://berrange.com" rel="noreferrer" target="_blank">http://berrange.com</a>      -o-    <a href="http://www.flickr.com/photos/dberrange/" rel="noreferrer" target="_blank">http://www.flickr.com/photos/<wbr>dberrange/</a> :|<br>
|: <a href="http://libvirt.org" rel="noreferrer" target="_blank">http://libvirt.org</a>              -o-             <a href="http://virt-manager.org" rel="noreferrer" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://entangle-photo.org" rel="noreferrer" target="_blank">http://entangle-photo.org</a>       -o-    <a href="http://search.cpan.org/%7Edanberr/" rel="noreferrer" target="_blank">http://search.cpan.org/~<wbr>danberr/</a> :|<br>
</font></span></blockquote></div><br></div></div>