<div dir="ltr">ping..</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 27, 2017 at 4:29 PM, Shivaprasad G Bhat <span dir="ltr"><<a href="mailto:sbhat@linux.vnet.ibm.com" target="_blank">sbhat@linux.vnet.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Commit afe6e58 & c4caab53 made necessary changes to use io-helpers<br>
during save and restore. The commit c4caab53 missed to remove the<br>
redundant check in qemuDomainSaveImageOpen() because of which<br>
virFileWrapperFdNew() is not called if bypass_cache is false.<br>
<br>
Signed-off-by: Shivaprasad G Bhat <<a href="mailto:sbhat@linux.vnet.ibm.com">sbhat@linux.vnet.ibm.com</a>><br>
---<br>
src/qemu/qemu_driver.c | 7 ++++---<br>
1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c<br>
index 516a851..ac89372 100644<br>
--- a/src/qemu/qemu_driver.c<br>
+++ b/src/qemu/qemu_driver.c<br>
@@ -6150,9 +6150,11 @@ qemuDomainSaveImageOpen(<wbr>virQEMUDriverPtr driver,<br>
virDomainDefPtr def = NULL;<br>
int oflags = open_write ? O_RDWR : O_RDONLY;<br>
virCapsPtr caps = NULL;<br>
+ unsigned int wrapperFlags = VIR_FILE_WRAPPER_NON_BLOCKING;<br>
<br>
if (bypass_cache) {<br>
int directFlag = virFileDirectFdFlag();<br>
+ wrapperFlags |= VIR_FILE_WRAPPER_BYPASS_CACHE;<br>
if (directFlag < 0) {<br>
virReportError(VIR_ERR_<wbr>OPERATION_FAILED, "%s",<br>
_("bypass cache unsupported by this system"));<br>
@@ -6166,9 +6168,8 @@ qemuDomainSaveImageOpen(<wbr>virQEMUDriverPtr driver,<br>
<br>
if ((fd = qemuOpenFile(driver, NULL, path, oflags, NULL, NULL)) < 0)<br>
goto error;<br>
- if (bypass_cache &&<br>
- !(*wrapperFd = virFileWrapperFdNew(&fd, path,<br>
- VIR_FILE_WRAPPER_BYPASS_CACHE)<wbr>))<br>
+ if (wrapperFd &&<br>
+ !(*wrapperFd = virFileWrapperFdNew(&fd, path, wrapperFlags)))<br>
goto error;<br>
<br>
if (saferead(fd, &header, sizeof(header)) != sizeof(header)) {<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/libvir-list</a><br>
</blockquote></div><br></div>