<div>
<br>
</div>
<div></div>
<p style="color: #A0A0A8;">On Thursday, 30 March 2017 at 10:03 PM, Martin Kletzander wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>Signed-off-by: Martin Kletzander <<a href="mailto:mkletzan@redhat.com">mkletzan@redhat.com</a>></div><div>---</div><div> src/libvirt_private.syms | 1 +</div><div> src/util/virsysfs.c | 17 ++++++++++++++++-</div><div> src/util/virsysfs.h | 6 ++++++</div><div> 3 files changed, 23 insertions(+), 1 deletion(-)</div><div><br></div><div>diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms</div><div>index 9e61accda3fc..3965ef3f89c9 100644</div><div>--- a/src/libvirt_private.syms</div><div>+++ b/src/libvirt_private.syms</div><div>@@ -2621,6 +2621,7 @@ virVasprintfInternal;</div><div><br></div><div><br></div><div> # util/virsysfs.h</div><div>+virSysfsDirOpen;</div><div> virSysfsGetCpuValueBitmap;</div><div> virSysfsGetCpuValueInt;</div><div> virSysfsGetCpuValueString;</div><div>diff --git a/src/util/virsysfs.c b/src/util/virsysfs.c</div><div>index c482e188a301..6686d8ddbfcb 100644</div><div>--- a/src/util/virsysfs.c</div><div>+++ b/src/util/virsysfs.c</div><div>@@ -25,7 +25,6 @@</div><div> #include "virsysfspriv.h"</div><div><br></div><div> #include "viralloc.h"</div><div>-#include "virfile.h"</div><div> #include "virlog.h"</div><div> #include "virstring.h"</div><div><br></div><div>@@ -120,6 +119,22 @@ virSysfsGetValueBitmap(const char *file,</div><div> * Per-CPU getters</div><div> */</div><div> int</div><div>+virSysfsDirOpen(const char *file,</div><div>+ DIR **dirp)</div><div>+{</div><div>+ char *path = NULL;</div><div>+</div><div>+ if (virAsprintf(&path, "%s/%s", sysfs_system_path, file) < 0)</div><div>+ return -1;</div><div>+</div><div>+ if (!virFileIsDir(path))</div><div>+ return -2;</div><div>+</div><div>+ return virDirOpen(dirp, path);</div><div>+}</div><div>+</div></div></div></span></blockquote><div>what if I need another util function like:</div><div> virSysfsDirResctrlOpen(const char *file, DIR **dirp)</div><div><br></div><div>do another copy and just modify path as:</div><div><br></div><div>if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0)</div><div><br></div><div>is that okay for you to duplicated code like this?</div><div><br></div><div>This is not so common a way to adding utils functions.</div><div><br></div><div>If I need another `sysfs_system_path`, for /sys/fs/resctrl</div><div>I need to add a new variable sysfs_resctrl_path, then do a copy</div><div>of this function with some modification.</div><div><br></div><div>Eli.</div><blockquote type="cite"><span><div>+ DIR **dirp)</div></span></blockquote><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div>+</div><div>+int</div><div> virSysfsGetCpuValueInt(unsigned int cpu,</div><div> const char *file,</div><div> int *value)</div><div>diff --git a/src/util/virsysfs.h b/src/util/virsysfs.h</div><div>index 1b24fc193a16..ff5012d62747 100644</div><div>--- a/src/util/virsysfs.h</div><div>+++ b/src/util/virsysfs.h</div><div>@@ -23,6 +23,8 @@</div><div><br></div><div> # include "internal.h"</div><div> # include "virbitmap.h"</div><div>+# include "virfile.h"</div><div>+</div><div><br></div><div> /*</div><div> * Generic getters</div><div>@@ -41,6 +43,10 @@ int</div><div> virSysfsGetValueBitmap(const char *file,</div><div> virBitmapPtr *value);</div><div><br></div><div>+int</div><div>+virSysfsDirOpen(const char *file,</div><div>+ DIR **dirp);</div><div>+</div><div><br></div><div> /*</div><div> * Per-CPU getters</div><div>-- </div><div>2.12.2</div><div><br></div><div>--</div><div>libvir-list mailing list</div><div><a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a></div><div><a href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>