<div><br></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div> </cells></div></div></div></span></blockquote><div>Okay, cool, this comes better than my patches and have some differences.</div><div>I am open with this as long as that it can meet cache allocation requires and</div><div>everyone will be happy. </div><div><br></div><div>I am ++ for this.</div><div><br></div><div>But I am not sure expose all of cache information in the capabilities XML.</div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div> </topology></div><div>+ <cache></div><div>+ <bank id='0' level='3' type='unified' size='8192' unit='KiB' cpus='0-7'/></div></div></div></span></blockquote><div>eg: if enabled CDP feature on the host, what the type of level=3 cache should be like?</div><div><br></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div>+ <bank id='0' level='2' type='unified' size='256' unit='KiB' cpus='0-1'/></div></div></div></span></blockquote><div>for the bank id, it’s per cache level unique right (data/instruction shares same id)? </div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div>+ <bank id='0' level='1' type='instruction' size='32' unit='KiB' cpus='0-1'/></div><div>+ <bank id='0' level='1' type='data' size='32' unit='KiB' cpus='0-1'/></div><div>+ <bank id='1' level='2' type='unified' size='256' unit='KiB' cpus='2-3'/></div><div>+ <bank id='1' level='1' type='instruction' size='32' unit='KiB' cpus='2-3'/></div><div>+ <bank id='1' level='1' type='data' size='32' unit='KiB' cpus='2-3'/></div><div>+ <bank id='2' level='2' type='unified' size='256' unit='KiB' cpus='4-5'/></div><div>+ <bank id='2' level='1' type='instruction' size='32' unit='KiB' cpus='4-5'/></div><div>+ <bank id='2' level='1' type='data' size='32' unit='KiB' cpus='4-5'/></div><div>+ <bank id='3' level='2' type='unified' size='256' unit='KiB' cpus='6-7'/></div><div>+ <bank id='3' level='1' type='instruction' size='32' unit='KiB' cpus='6-7'/></div><div>+ <bank id='3' level='1' type='data' size='32' unit='KiB' cpus='6-7'/></div><div>+ </cache></div></div></div></span></blockquote><div><br></div><div>This’s really good that you have work this out by expose all these out to capabilities,</div><div>and it will be much easy to let resctrl keep focus on cache allocation.</div><div><br></div><div>So if util/virresctrl.c would like to access some cache abilities, it will first get <span style="orphans: 2; white-space: pre-wrap; widows: 2;">virCapsPtr.</span><span style="orphans: 2; white-space: pre-wrap; widows: 2;">host.caches,</span></div><div style="orphans: 2; widows: 2;">right?</div><div><br></div><div>but I am not sure if that’s be okay to expose all cache information which we can not</div><div>do the allocation yet.</div><div><br></div><div>How can a user/admin to know from capabilities?</div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div> </host></div><div><br></div><div> </capabilities></div><div>diff --git a/tests/vircaps2xmltest.c b/tests/vircaps2xmltest.c</div><div>index ffbe9a783811..dda0757766a8 100644</div><div>--- a/tests/vircaps2xmltest.c</div><div>+++ b/tests/vircaps2xmltest.c</div><div>@@ -58,7 +58,8 @@ test_virCapabilities(const void *opaque)</div><div> if (!caps)</div><div> goto cleanup;</div><div><br></div><div>- if (virCapabilitiesInitNUMA(caps) < 0)</div><div>+ if (virCapabilitiesInitNUMA(caps) < 0 ||</div><div>+ virCapabilitiesInitCaches(caps) < 0)</div><div> goto cleanup;</div><div><br></div><div> virSysfsSetSystemPath(NULL);</div><div>-- </div><div>2.12.2</div><div><br></div><div>--</div><div>libvir-list mailing list</div><div><a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a></div><div><a href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>