<div>
<br>
</div>
<div></div>
<p style="color: #A0A0A8;">On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote:</div><blockquote type="cite"><div><div>On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote:</div><blockquote type="cite"><div><blockquote type="cite"><div><div><br></div><div>The name doesn't really matter that much, 'scope' makes a bit more</div><div>sense, 'type' is consistent with the cache bank specification, I'm fine</div><div>with any. The big question here was if it is possible to have:</div><div><br></div><div><bank type='unified'></div><div><control scope='code'/></div><div><control scope='data'/></div><div></bank></div><div><br></div><div>And from what you say, the simple answer is "yes". So we need to have</div><div>the attribute there in the control element as well.</div></div></blockquote><div><br></div><div><br></div><div>Dan/Martin</div><div><br></div><div>Could you please advice which should be changed ? LoL</div><div><br></div><div>This is the output if I enabled CDP</div><div><br></div><div> <cache></div><div> <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'></div><div> <control min='768' unit='KiB' type='instruction' nallocations='8'/></div><div> <control min='768' unit='KiB' type='data' nallocations='8'/></div><div> </bank></div><div> <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'></div><div> <control min='768' unit='KiB' type='instruction' nallocations='8'/></div><div> <control min='768' unit='KiB' type='data' nallocations='8'/></div><div> </bank></div><div> </cache></div><div><br></div><div><br></div><div>1. change nallocations to allocations/max_allocation?</div></div></blockquote><div><br></div><div>Dan said he's fine with both, I'd probably go for max_allocations</div><div><br></div><blockquote type="cite"><div>2. change type to scope ?</div></blockquote><div><br></div><div>I don't care, pros for both in the previous mail.</div></div></blockquote><div><br></div><div>Both attributes take the same enum values, so it is best to be consistent</div><div>with the attribute name.</div><div><br></div></div></div></span></blockquote><div>Thanks very much for Daniel & Martin</div><div><br></div><div>Forgive me to ping you again, just make sure I am in correct place :</div><div><br></div><div>If I read your comments correctly, we can go with: </div><div><br></div><div><div><cache></div><div> <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'></div><div> <control min='768' unit='KiB' scope=‘code' max_allocation ='8'/></div><div> <control min='768' unit='KiB' scope=‘data' max_allocation ='8'/></div><div> </bank></div><div> <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'></div><div><div> <control min='768' unit='KiB' scope=‘code' max_allocation ='8'/></div><div> <control min='768' unit='KiB' scope=‘data' max_allocation ='8'/></div></div><div> </bank></div><div></cache></div></div><div><br></div><div>@Daniel, </div><div><br></div><div>the enum values are same with `type`</div><div><br></div><div>unified: 0</div><div>instruction: 1</div><div>data: 2</div><div><br></div><div>but scope should be both(0)/code(1)/data(2), so the attribute name will be</div><div>`scope`. As we need create another Type{to from}String marco for easy read from /sys/fs/resctr/LxDATA/CODE .</div><div><br></div><div><br></div><div>Regards,</div><div><br></div><div>Eli</div><div><br></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div></div><div>Regards,</div><div>Daniel</div><div>-- </div><div>|: <a href="http://berrange.com">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/">http://www.flickr.com/photos/dberrange/</a> :|</div><div>|: <a href="http://libvirt.org">http://libvirt.org</a> -o- <a href="http://virt-manager.org">http://virt-manager.org</a> :|</div><div>|: <a href="http://entangle-photo.org">http://entangle-photo.org</a> -o- <a href="http://search.cpan.org/~danberr/">http://search.cpan.org/~danberr/</a> :|</div></div></div></span>
</blockquote>
<div>
<br>
</div>