<div>
<br>
</div>
<div></div>
<p style="color: #A0A0A8;">On Thursday, 6 April 2017 at 9:04 PM, Martin Kletzander wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>On Thu, Apr 06, 2017 at 01:25:35PM +0100, Daniel P. Berrange wrote:</div><blockquote type="cite"><div><div>On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote:</div><blockquote type="cite"><div><div>This patch is based on Martin's cache branch.</div><div><br></div><div>This patch amends the cache bank capability as follow:</div><div><br></div><div><cache></div><div> <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'></div><div> <control min='768' unit='KiB' type='unified' nallocations='4'/></div><div> </bank></div></div></blockquote><div><br></div><div>Why do we need to report 'type' on both bank & control elements. Are they</div><div>really expected to have different values ?</div></div></blockquote><div></div></div></div></span></blockquote><div>There’s a discussion from <a href="https://www.redhat.com/archives/libvir-list/2017-March/msg01689.html">https://www.redhat.com/archives/libvir-list/2017-March/msg01689.html</a></div><div><br></div><div>I think I made a mistake here, it should be ’scope’ instead of ’type’ here.</div><div><br></div><div>No matter what’s it should be, at least we need to identify if the host enabled CDP for L3 cache or not.</div><div><br></div><div>If enabled CDP on host, the resctrl looks like this:</div><div><br></div><div><div>root@s2600wt:/sys/fs/resctrl# cat schemata</div><div>L3DATA:0=fffff;1=fffff</div><div>L3CODE:0=fffff;1=fffff</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3</div><div>L3CODE/ L3DATA/</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3DATA/num_closids</div><div>8</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3CODE/num_closids</div><div>8</div></div><div><br></div><div>as you can see that num_closids are divided into 2 part (compared to 16 without CDP),</div><div> but other info are still same</div><div><br></div><div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3CODE/cbm_mask</div><div>fffff</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3CODE/min_cbm_bits</div><div>1</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3DATA/cbm_mask</div><div>fffff</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3DATA/min_cbm_bits</div><div>1</div></div><div><br></div><div>------------------------------------------</div><div>below output are from disable CDP:</div><div><br></div><div><div>root@s2600wt:/sys/fs/resctrl# cat schemata</div><div>L3:0=fffff;1=fffff</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3/</div><div>cbm_mask min_cbm_bits num_closids</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3/cbm_mask</div><div>fffff</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3/min_cbm_bits</div><div>1</div><div>root@s2600wt:/sys/fs/resctrl# cat info/L3/num_closids</div><div>16</div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div> </div></div></div></span></blockquote><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><div></div><div>That's one of my questions I had way back in some of the previous</div><div>discussions. Did not get the answer. I suspect there is a reason to</div><div>whether CDP is enabled or not and it is not just the type of the cache</div><div>bank itself. If it is, then CDP makes no sense for us at all, actually</div><div>for anyone who has access to cache information and that would mean bad</div><div>design of that thing. And that's not something I would expect from this</div><div>functionality.</div><div><br></div><blockquote type="cite"><div><div><br></div><div>Regards,</div><div>Daniel</div><div>--</div><div>|: <a href="http://berrange.com">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/">http://www.flickr.com/photos/dberrange/</a> :|</div><div>|: <a href="http://libvirt.org">http://libvirt.org</a> -o- <a href="http://virt-manager.org">http://virt-manager.org</a> :|</div><div>|: <a href="http://entangle-photo.org">http://entangle-photo.org</a> -o- <a href="http://search.cpan.org/~danberr/">http://search.cpan.org/~danberr/</a> :|</div></div></blockquote></div><div><div>--</div><div>libvir-list mailing list</div><div><a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a></div><div><a href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>