<div dir="ltr">Ah, you're absolutely right, I completely forgot this function existed. </div> <div class="gmail_quote"><div dir="ltr">On Tue, Apr 18, 2017 at 5:18 PM Matthias Bolte <<a href="mailto:matthias.bolte@googlemail.com">matthias.bolte@googlemail.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">2017-04-18 0:36 GMT+02:00 Sri Ramanujam <<a href="mailto:sramanujam@datto.com" target="_blank">sramanujam@datto.com</a>>: > Add virNumToStr(), which safely converts numbers into their string > representation. > > Functions added: > * virNumToStr_l > * virNumToStr_ul > --- > src/util/virstring.c | 34 ++++++++++++++++++++++++++++++++++ > src/util/virstring.h | 8 ++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/src/util/virstring.c b/src/util/virstring.c > index 69abc26..f0d9e19 100644 > --- a/src/util/virstring.c > +++ b/src/util/virstring.c > @@ -536,6 +536,40 @@ virStrToDouble(char const *s, > return 0; > } > > +/** > + * Converts signed number to string representation. The caller is responsible > + * for freeing the result. > + */ > +int > +virNumToStr_l(long num, char **dst) > +{ > + int sz; > + > + sz = snprintf(NULL, 0, "%ld", num); > + if (sz > 0 && VIR_ALLOC_N(*dst, sz + 1) < 0) > + return -1; > + > + snprintf(*dst, sz + 1, "%ld", num); > + return 0; > +} > + > +/** > + * Converts unsigned number to string representation. The caller is responsible > + * for freeing the result. > + */ > +int > +virNumToStr_ul(unsigned long num, char **dst) > +{ > + int sz; > + > + sz = snprintf(NULL, 0, "%lu", num); > + if (sz > 0 && VIR_ALLOC_N(*dst, sz + 1) < 0) > + return -1; > + > + snprintf(*dst, sz + 1, "%lu", num); > + return 0; > +} > + What's the gain of if (virNumToStr_ul(memory_mb, &memory_str) < 0) goto cleanup; over if (virAsprintf(&memory_str, "%lu", memory_mb) < 0) goto cleanup; ? I think those two new functions are not necessary at all. -- Matthias Bolte <a href="http://photron.blogspot.com" rel="noreferrer" target="_blank">http://photron.blogspot.com</a> </blockquote></div><div dir="ltr">-- </div><div data-smartmail="gmail_signature"><div dir="ltr"><table style="border-collapse:collapse;width:270pt" dir="ltr" cellspacing="0" cellpadding="0" border="0" width="270"><tbody><tr style="min-height:17pt" height="17"><td style="min-height:17pt;width:270pt" width="270" height="17">Sri Ramanujam </td> </tr> <tr style="min-height:16pt" height="16"> <td style="min-height:16pt" height="16">Software Engineer</td> </tr> <tr style="min-height:16pt" height="16"> <td style="min-height:16pt;padding-bottom:0in;padding-top:0in" height="16">Datto, Inc.</td> </tr> <tr style="min-height:16pt" height="16"> <td style="min-height:16pt;padding-bottom:0in;padding-top:0in" height="16"></td> </tr> <tr style="min-height:16pt" height="16"> <td style="min-height:16pt;padding-bottom:0in;padding-top:0in" height="16"> <a href="http://www.datto.com">www.datto.com</a> </td> </tr> <tr style="min-height:16pt" height="16"> <td style="min-height:16pt;padding-bottom:0in;padding-top:0in" height="16"> <a href="http://datto.com/datto-signature/"><img src="http://connect.dattobackup.com/rs/datto/images/generic-sig.png"></a> </td> </tr> <tr style="min-height:15pt" height="15"> <td style="min-height:15pt;padding-bottom:0in;padding-top:0in" height="15"> Join the conversation! <a style="font-family:verdana,arial,helvetica,sans-serif" href="http://www.facebook.com/dattoinc"><img src="https://s3.amazonaws.com/images.wisestamp.com/facebook.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="Facebook" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="https://twitter.com/dattobackup"><img src="http://dattobackup.com/wp-content/uploads/2014/06/twitter.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="Twitter" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="http://www.linkedin.com/company/1477873?trk=tyah"><img src="https://s3.amazonaws.com/images.wisestamp.com/linkedin.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="LinkedIn" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="http://pinterest.com/dattobackup/"><img src="https://s3.amazonaws.com/images.wisestamp.com/pinterest.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="pinterest" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="http://blog.dattobackup.com/blog"><img src="https://s3.amazonaws.com/images.wisestamp.com/blogRSS.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="Blog RSS" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="http://www.youtube.com/user/DattoInc/featured"><img src="https://s3.amazonaws.com/images.wisestamp.com/youtube.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="YouTube" border="0" width="16" height="16"></a> <a style="font-family:verdana,arial,helvetica,sans-serif" href="https://plus.google.com/u/0/108292366419623632143/posts"><img src="https://s3.amazonaws.com/images.wisestamp.com/googlepluspage.png" style="padding: 0px 0px 5px; vertical-align: middle;" alt="Google Plus Page" border="0" width="16" height="16"></a></td></tr></tbody></table> </div></div>