<div class="zcontentRow"> ＞On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: ＞＞ Creating tap device and adding the device to bridge are not atomic operation. ＞＞ Similarly deleting tap device and removing it from bridge are not atomic operation. ＞＞The Problem occurs when two vms start and shutdown. When one vm with the nic ＞＞ named "vnet0" stopping, it deleted tap device but not removing port from bridge. ＞＞ At this time, another vm created the tap device named "vnet0" and added port to the ＞＞ same bridge. Then, the first vm deleted the tap device from the same bridge. ＞＞ Finally, the tap device of the second vm don't attached to the bridge. ＞＞ So, we can add domid to vm's nic name. For example, the vm's domid is 1 and vnet0 ＞＞ is renamed to vnet1.0. ＞Surely deleting the NIC automatically removes it from the bridge so we ＞can just remove the code that delets the bridge port.i have done some tests for a tap + openvswitch bridge network. i find the nic named "vnet0" don't exsit before calling the virNetDevOpenvswitchRemovePort.i think the tap is deleted not by removingport from bridge. i think hotpluging net has the same problem. by the way: my company's e-mail does not support thread posting and has some other problems. i believe that my colleagues can soon resloved them. <div class="zMailSign"><div><div><div><div> 为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。芦志朋 luzhipeng IT开发工程师 IT Development Engineer 操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product <table style="color: rgb(0, 0, 0); font-family: 宋体; widows: 1;"><tbody><tr class="firstRow"><td valign="top" width="100"><img id="sign-icon" src="cid:9ae3e214c17d49ed935d87c674ba3ee2" width="130" height="120"></td><td valign="top" width="500"><img id="sign-logo" src="cid:24242e5637af428891c4db731e7765ad" width="115" height="38"> 深圳市南山区科技南路55号中兴通讯研发大楼33楼 33/F, R&D Building, ZTE Corporation Hi-tech Road South, Hi-tech Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx M: +86 xxxxxxxxxxx E: lu.zhipeng@zte.com.cn <a href="http://www.zte.com.cn/" target="_blank">www.zte.com.cn</a></td></tr></tbody></table></div></div></div></div></div><div><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;" language-data="HistoryOrgTxt">原始邮件</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div>发件人： ＜berrange@redhat.com＞;</div><div>收件人：芦志朋10108272;</div><div>抄送人： ＜libvir-list@redhat.com＞;</div><div>日期：2017年04月28日 19:27</div><div>主题：Re: [libvirt] [PATCH] qemu: change the name of tap device for a tapand bridge network</div></div> <div>On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: ＞ Creating tap device and adding the device to bridge are not atomic operation. ＞ Similarly deleting tap device and removing it from bridge are not atomic operation. ＞ The Problem occurs when two vms start and shutdown. When one vm with the nic ＞ named "vnet0" stopping, it deleted tap device but not removing port from bridge. ＞ At this time, another vm created the tap device named "vnet0" and added port to the ＞ same bridge. Then, the first vm deleted the tap device from the same bridge. ＞ Finally, the tap device of the second vm don't attached to the bridge. ＞ So, we can add domid to vm's nic name. For example, the vm's domid is 1 and vnet0 ＞ is renamed to vnet1.0. Surely deleting the NIC automatically removes it from the bridge so we can just remove the code that delets the bridge port. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list </div> </div></div></div></div> </div>