<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Possibly related I notice race conditions caused by vnic never getting loaded if an existing bridge is already up (by OS init scripts etc) and stopping VM's from getting started. </div><div class="gmail_default" style="font-family:verdana,sans-serif">Often this is behavior you want ; i.e having Host Hypervisor NIC's added and up before libvirtd sets up it's nics/bridges. </div></div><div class="gmail_extra"> <div class="gmail_quote">On 29 April 2017 at 11:15, <<a href="mailto:lu.zhipeng@zte.com.cn" target="_blank">lu.zhipeng@zte.com.cn</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-7555536877149155405zcontentRow"> ＞On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: ＞＞ Creating tap device and adding the device to bridge are not atomic operation. ＞＞ Similarly deleting tap device and removing it from bridge are not atomic operation. ＞＞The Problem occurs when two vms start and shutdown. When one vm with the nic ＞＞ named "vnet0" stopping, it deleted tap device but not removing port from bridge. ＞＞ At this time, another vm created the tap device named "vnet0" and added port to the ＞＞ same bridge. Then, the first vm deleted the tap device from the same bridge. ＞＞ Finally, the tap device of the second vm don't attached to the bridge. ＞＞ So, we can add domid to vm's nic name. For example, the vm's domid is 1 and vnet0 ＞＞ is renamed to vnet1.0. ＞Surely deleting the NIC automatically removes it from the bridge so we ＞can just remove the code that delets the bridge port.i have done some tests for a tap + openvswitch bridge network. i find the nic named "vnet0" don't exsit before calling the virNetDevOpenvswitchRemovePort.i think the tap is deleted not by removingport from bridge. i think hotpluging net has the same problem. by the way: my company's e-mail does not support thread posting and has some other problems. i believe that my colleagues can soon resloved them. <div class="m_-7555536877149155405zMailSign"><div><div><div><div> 为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。芦志朋 luzhipeng IT开发工程师 IT Development Engineer 操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product <table style="color:rgb(0,0,0);font-family:宋体"><tbody><tr class="m_-7555536877149155405firstRow"><td width="100" valign="top"><img id="m_-7555536877149155405sign-icon" src="cid:9ae3e214c17d49ed935d87c674ba3ee2" width="130" height="120"></td><td width="500" valign="top"><img id="m_-7555536877149155405sign-logo" src="cid:24242e5637af428891c4db731e7765ad" width="115" height="38"> 深圳市南山区科技南路55号中兴通讯研发大楼33楼 33/F, R&D Building, ZTE Corporation Hi-tech Road South, Hi-tech Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx M: +86 xxxxxxxxxxx E: <a href="mailto:lu.zhipeng@zte.com.cn" target="_blank">lu.zhipeng@zte.com.cn</a> <a href="http://www.zte.com.cn/" target="_blank">www.zte.com.cn</a></td></tr></tbody></table></div></div></div></div></div><div><div class="m_-7555536877149155405zhistoryRow" style="display:block"><div class="m_-7555536877149155405zhistoryDes" style="width:100%;height:28px;line-height:28px;background-color:#e0e5e9;color:#1388ff;text-align:center">原始邮件</div><div id="m_-7555536877149155405zwriteHistoryContainer"><div class="m_-7555536877149155405control-group m_-7555536877149155405zhistoryPanel"><div class="m_-7555536877149155405zhistoryHeader" style="padding:8px;background-color:#f5f6f8"><div>发件人： ＜<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>＞;</div><div>收件人：芦志朋10108272;</div><div>抄送人： ＜<a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a>＞;</div><div>日期：2017年04月28日 19:27</div><div>主题：Re: [libvirt] [PATCH] qemu: change the name of tap device for a tapand bridge network</div></div> <div>On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: ＞ Creating tap device and adding the device to bridge are not atomic operation. ＞ Similarly deleting tap device and removing it from bridge are not atomic operation. ＞ The Problem occurs when two vms start and shutdown. When one vm with the nic ＞ named "vnet0" stopping, it deleted tap device but not removing port from bridge. ＞ At this time, another vm created the tap device named "vnet0" and added port to the ＞ same bridge. Then, the first vm deleted the tap device from the same bridge. ＞ Finally, the tap device of the second vm don't attached to the bridge. ＞ So, we can add domid to vm's nic name. For example, the vm's domid is 1 and vnet0 ＞ is renamed to vnet1.0. Surely deleting the NIC automatically removes it from the bridge so we can just remove the code that delets the bridge port. Regards, Daniel -- |: <a href="https://berrange.com" target="_blank">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange" target="_blank">https://www.flickr.com/photos/dberrange</a> :| |: <a href="https://libvirt.org" target="_blank">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com" target="_blank">https://fstop138.berrange.com</a> :| |: <a href="https://entangle-photo.org" target="_blank">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange" target="_blank">https://www.instagram.com/dberrange</a> :| -- libvir-list mailing list <a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/libvir-list" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a> </div> </div></div></div></div> </div> -- libvir-list mailing list <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/libvir-list</a> </blockquote></div> </div>