<div dir="ltr"><div><div><div><div><div>Hi <span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD">Cédric,<br><br>您</span><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD">好：）</span><br><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD"></span></div><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD">I'm sorry that I missed the mail. <br></span><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD">But currently I can not reproduce it. </span><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD"><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><br>For the error by net-create, it is </span><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><span class="m_5934824203795626004gmail-m_-3471493338416586133gmail-gt-baf-back m_5934824203795626004gmail-m_-3471493338416586133gmail-gt-baf-hl">executed when I set </span><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span>accept_ra to 1.<br><br></div>I have just test on libvirt-3.2.0-4.el7.x86_64<span id="transmark" style="display:none;width:0px;height:0px"></span>, the behavior changes, it seems like there is no check for accept_ra before start a network with ipv6.<br><br></div>1. define and start a network with ipv6 settings<br># virsh net-dumpxml default6<br><network><br> <name>default6</name><br> <uuid>c502d02c-fbd0-49d9-91e4-<wbr>0fcf0ef159d0</uuid><br> <forward mode='nat'/><br> <bridge name='virbr4' stp='on' delay='0'/><br> <mac address='52:54:00:04:d5:3c'/><br> <ip address='192.168.10.1' netmask='255.255.255.0'><br> <dhcp><br> <range start='192.168.10.2' end='192.168.10.254'/><br> </dhcp><br> </ip><br> <ip family='ipv6' address='2001:db8:ca2:2::1' prefix='64'><br> <dhcp><br> <range star<span id="m_5934824203795626004transmark" style="display:none;width:0px;height:0px"></span>t='2001:db8:ca2:2:1::10' end='2001:db8:ca2:2:1::ff'/><br> </dhcp><br> </ip><br></network><br><br># cat /proc/sys/net/ipv6/conf/enp0s2<wbr>5/accept_ra<br>1<br><br># virsh net-start default6 =====> the network can start as well with accept_ra=1<br>Network default6 started<br><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><br></div><div>It seems that the "virNetDevIPGetAcceptRA()" in patch "network: check accept_ra before enabling ipv6 forwarding" with commit 00d28a78 is not executed when I start a network. Please help to check, Thank you.<span id="m_5934824203795626004gmail-transmark" style="display:none;width:0px;height:0px"></span><span id="m_5934824203795626004gmail-transmark" style="display:none;width:0px;height:0px"></span><br></div><br></div><span id="m_5934824203795626004gmail-m_-3471493338416586133transmark" style="display:none;width:0px;height:0px"></span><br><div><div><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><br><div><div><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span><br><div><div><br><br><br><br><span name="Cédric Bosdonnat" class="m_5934824203795626004gmail-m_-3471493338416586133gmail-m_8311982907334151396gmail-gD"><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span></span><div><div><div><span id="m_5934824203795626004gmail-m_-3471493338416586133gmail-transmark" style="display:none;width:0px;height:0px"></span></div></div></div></div></div></div></div></div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div><div>Best Regards,<br></div>Yalan Zhang<br></div>IRC: yalzhang<br></div>Internal phone: 8389413<br><div><div><div><span style="display:none;width:0px;height:0px"></span></div></div></div></div></div></div> <br><div class="gmail_quote">On Tue, Apr 18, 2017 at 5:54 PM, Cedric Bosdonnat <span dir="ltr"><<a href="mailto:cbosdonnat@suse.com" target="_blank">cbosdonnat@suse.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yalan 你好<br> <span class=""><br> On Mon, 2017-04-17 at 17:30 +0800, Yalan Zhang wrote:<br> > I have tested it, it works well. But the interface name will repeat 2 times. <br> > Please help to confirm this, and if below test for a single port host is enough?<br> ><br> > # cat /proc/sys/net/ipv6/conf/<wbr>enp0s25/accept_ra<br> > 1<br> ><br> > enable network default with ipv6 ip section<br> ><br> > # virsh net-start default<br> > error: Failed to start network default<br> > error: internal error: Check the host setup: enabling IPv6 forwarding with RA routes without accept_ra set to 2 is<br> > likely to cause routes loss. Interfaces to look at: enp0s25, enp0s25<br> <br> </span>Just to help me confirm my intuition: do you have several RA routes defined<br> for the same device?<br> <span class=""><br> > # echo 2 > /proc/sys/net/ipv6/conf/<wbr>enp0s25/accept_ra<br> ><br> > # virsh net-start default<br> > Network default started<br> ><br> > try create:<br> ><br> > # virsh net-create default.xml<br> > error: Failed to create network from default.xml<br> > error: internal error: Check the host setup: enabling IPv6 forwarding with RA routes without accept_ra set to 2 is<br> > likely to cause routes loss. Interfaces to look at: enp0s25, enp0s25<br> <br> </span>This one sounds weird: if the accept_ra is set to 2 as you report you did,<br> you shouldn't get that error.<br> <br> --<br> Cedric<br> <div class="HOEnZb"><div class="h5"><br> > On Wed, Mar 15, 2017 at 10:45 PM, Cédric Bosdonnat <<a href="mailto:cbosdonnat@suse.com">cbosdonnat@suse.com</a>> wrote:<br> > > Hi Laine, all,<br> > ><br> > > Here is the v2 of my series. The changes are:<br> > ><br> > > * Add a commit to create a virNetDevGetName() function<br> > > * Fix Laine's comments<br> > ><br> > > Cédric Bosdonnat (5):<br> > > util: extract the request sending code from virNetlinkCommand()<br> > > util: add virNetlinkDumpCommand()<br> > > bridge_driver.c: more uses of SYSCTL_PATH<br> > > util: add virNetDevGetName() function<br> > > network: check accept_ra before enabling ipv6 forwarding<br> > ><br> > > src/libvirt_private.syms | 3 +<br> > > src/network/bridge_driver.c | 25 ++++---<br> > > src/util/virnetdev.c | 19 ++++++<br> > > src/util/virnetdev.h | 2 +<br> > > src/util/virnetdevip.c | 158 ++++++++++++++++++++++++++++++<wbr>++++++++++++++<br> > > src/util/virnetdevip.h | 1 +<br> > > src/util/virnetlink.c | 145 ++++++++++++++++++++++++++++++<wbr>----------<br> > > src/util/virnetlink.h | 9 +++<br> > > 8 files changed, 319 insertions(+), 43 deletions(-)<br> > ><br> > > --<br> > > 2.11.0<br> > ><br> > > --<br> > > libvir-list mailing list<br> > > <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><br> > > <a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/libvir-list</a><br> ><br> ><br> ><br> </div></div></blockquote></div><br></div>