<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/21/2017 01:02 PM, Peter Krempa
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20170621073253.GH7802@andariel.pipo.sk">
<pre wrap="">On Wed, Jun 21, 2017 at 05:07:49 +0530, Kothapally Madhu Pavan wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This commit adds qemu driver implementation to edit xml
configuration of managed save state file of a domain.
Signed-off-by: Kothapally Madhu Pavan <a class="moz-txt-link-rfc2396E" href="mailto:kmp@linux.vnet.ibm.com"><kmp@linux.vnet.ibm.com></a>
---
src/qemu/qemu_driver.c | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c9b3ef3..7ce6464 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6837,6 +6837,43 @@ qemuDomainManagedSaveGetXMLDesc(virDomainPtr dom, unsigned int flags)
return ret;
}
+static int
+qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml,
+ unsigned int flags)
+{
+ virQEMUDriverPtr driver = dom->conn->privateData;
+ virConnectPtr conn = dom->conn;
+ virDomainObjPtr vm;
+ char *path = NULL;
+
+ if (!(vm = qemuDomObjFromDomain(dom)))
+ return -1;
+
+ path = qemuDomainManagedSavePath(driver, vm);
+ if (!path)
+ goto error;
+
+ virDomainObjEndAPI(&vm);
+
+ if (conn->driver->domainSaveImageDefineXML) {
+ int ret;
+ ret = qemuDomainSaveImageDefineXML(conn, path, dxml, flags);
+
+ VIR_FREE(path);
+
+ if (ret < 0)
+ goto error;
+ return ret;
+ }
</pre>
</blockquote>
<pre wrap="">
This implementation is horrible. Please call the qemu implementation
directly or extract useful parts rather than going through the driver
pointers.</pre>
</blockquote>
<span style="font-size: 10pt !important; font-family: Cantarell;
color: rgb(0, 0, 0);" class="left">I was trying to follow the
pattern of other APIs and I didn't realize the pointers are not
necessary. Thanks for the comments. Fixing that in the next
version.<br>
</span>
<blockquote type="cite"
cite="mid:20170621073253.GH7802@andariel.pipo.sk">
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>