<div dir="ltr">Gentle ping.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 18, 2017 at 10:27 PM, Nitesh Konkar <span dir="ltr"><<a href="mailto:niteshkonkar.libvirt@gmail.com" target="_blank">niteshkonkar.libvirt@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">libvirtd throws unhandled signal 11 on ppc while running<br>
virsh cpu-compare with missing model tag in the xml. This<br>
patch errors out in such situation.<br>
<br>
Signed-off-by: Nitesh Konkar <<a href="mailto:nitkon12@linux.vnet.ibm.com">nitkon12@linux.vnet.ibm.com</a>><br>
---<br>
src/cpu/cpu_ppc64.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c<br>
index b58e80a..c11ac9f 100644<br>
--- a/src/cpu/cpu_ppc64.c<br>
+++ b/src/cpu/cpu_ppc64.c<br>
@@ -247,6 +247,12 @@ ppc64ModelFromCPU(const virCPUDef *cpu,<br>
{<br>
struct ppc64_model *model;<br>
<br>
+ if (!cpu->model) {<br>
+ virReportError(VIR_ERR_<wbr>INVALID_ARG, "%s",<br>
+ _("no guest CPU model specified"));<br>
+ return NULL;<br>
+ }<br>
+<br>
if (!(model = ppc64ModelFind(map, cpu->model))) {<br>
virReportError(VIR_ERR_<wbr>INTERNAL_ERROR,<br>
_("Unknown CPU model %s"), cpu->model);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.5<br>
<br>
</font></span></blockquote></div><br></div>