<div dir="ltr">Hello,<div><br></div><div>I have not got revert back since I sent last patch on 12/22/2017, just want to know how it is going on?</div><div><br></div><div>Regards,</div><div>Charles.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 22, 2017 at 3:08 PM, Charles Kelimod <span dir="ltr"><<a href="mailto:lichstor@gmail.com" target="_blank">lichstor@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Peter,<div><br></div><div>I will remove the comment.</div><div>I did the test and noticed the issue, then I reverted to a clean workspace which is cloned from the libvirt git datastore, however I meet the same issue when running the test:</div><div>VIR_TEST_DEBUG=1 VIR_TEST_EXPENSIVE=1 make check<br></div><div>Therefor I thought it was something wrong in other place or my environment.</div><div><br></div><div>Regards,</div><div>Charles.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 21, 2017 at 9:24 PM, Peter Krempa <span dir="ltr"><<a href="mailto:pkrempa@redhat.com" target="_blank">pkrempa@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_5217011708572237991HOEnZb"><div class="m_5217011708572237991h5">On Thu, Dec 21, 2017 at 16:27:15 +0800, <a href="mailto:lichstor@gmail.com" target="_blank">lichstor@gmail.com</a> wrote:<br>
> From: zhangshengyu <<a href="mailto:zhangshengyu@fusionstack.cn" target="_blank">zhangshengyu@fusionstack.cn</a>><br>
><br>
> ---<br>
>  src/conf/domain_conf.c                             | 10 ++++++<br>
>  src/qemu/qemu_block.c                              | 24 +++++++++++--<br>
>  src/qemu/qemu_command.c                            |  3 ++<br>
>  src/qemu/qemu_parse_command.c                      | 10 +++++-<br>
>  src/storage/storage_backend_gl<wbr>uster.c              |  1 +<br>
>  src/util/virstoragefile.c                          |  3 +-<br>
>  src/util/virstoragefile.h                          |  1 +<br>
>  .../qemuargv2xmldata/disk-driv<wbr>e-network-iser.args  | 25 +++++++++++++<br>
>  tests/qemuargv2xmldata/disk-dr<wbr>ive-network-iser.xml | 41 ++++++++++++++++++++++<br>
>  tests/qemuargv2xmltest.c                           |  1 +<br>
>  .../qemuxml2argvdata/disk-driv<wbr>e-network-iser.args  | 29 +++++++++++++++<br>
>  tests/qemuxml2argvdata/disk-dr<wbr>ive-network-iser.xml | 37 +++++++++++++++++++<br>
>  tests/qemuxml2argvtest.c                           |  1 +<br>
>  .../qemuxml2xmloutdata/disk-dr<wbr>ive-network-iser.xml | 41 ++++++++++++++++++++++<br>
>  tests/qemuxml2xmltest.c                            |  1 +<br>
>  15 files changed, 224 insertions(+), 4 deletions(-)<br>
>  create mode 100644 tests/qemuargv2xmldata/disk-dr<wbr>ive-network-iser.args<br>
>  create mode 100644 tests/qemuargv2xmldata/disk-dr<wbr>ive-network-iser.xml<br>
>  create mode 100644 tests/qemuxml2argvdata/disk-dr<wbr>ive-network-iser.args<br>
>  create mode 100644 tests/qemuxml2argvdata/disk-dr<wbr>ive-network-iser.xml<br>
>  create mode 100644 tests/qemuxml2xmloutdata/disk-<wbr>drive-network-iser.xml<br>
><br>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c<br>
> index 9a62bc472..5767575d0 100644<br>
> --- a/src/conf/domain_conf.c<br>
> +++ b/src/conf/domain_conf.c<br>
> @@ -7080,6 +7080,7 @@ virDomainStorageNetworkParseHo<wbr>sts(xmlNodePtr node,<br>
>                                    virStorageNetHostDefPtr *hosts,<br>
>                                    size_t *nhosts)<br>
>  {<br>
> +    char *transport = NULL;<br>
>      xmlNodePtr child;<br>
><br>
>      for (child = node->children; child; child = child->next) {<br>
> @@ -7091,6 +7092,11 @@ virDomainStorageNetworkParseHo<wbr>sts(xmlNodePtr node,<br>
>          }<br>
>      }<br>
><br>
> +    if ((*hosts) && (transport = virXMLPropString(node, "transport"))) {<br>
> +        //VIR_WARN("missing network source transport type");<br>
<br>
</div></div>We don't allow C99 style comments.<br>
<br>
Also apparently you STILL did not run the test suite before submission:<br>
<br>
../build-aux/test-driver: line 107:  2113 Segmentation fault      "$@" > $log_file 2>&1<br>
FAIL: qemuargv2xmltest<br>
<br>
../build-aux/test-driver: line 107:  2051 Segmentation fault      "$@" > $log_file 2>&1<br>
FAIL: qemuxml2xmltest<br>
<br>
FAIL: virschematest<br>
<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>