<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 2018年01月09日 18:40, Jiri Denemark
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20180109104002.GA5293@orkuz.home">
<pre wrap="">On Mon, Jan 08, 2018 at 19:06:43 +0800, Feng, Shaohe wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 2018年01月05日 02:52, John Ferlan wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 12/17/2017 06:02 PM, Shaohe Feng wrote:
</pre>
<blockquote type="cite">
<pre wrap="">We can start qemu with a "cpu,+la57" to set 57-bit vitrual address
space. So VM can be aware that it need to enable 5-level paging.
Corresponding QEMU commits:
al57 6c7c3c21f95dd9af8a0691c0dd29b07247984122
---
src/cpu/cpu_map.xml | 3 +++
1 file changed, 3 insertions(+)
</pre>
</blockquote>
<pre wrap="">I think if you go through history of cpu_map.xml changes you'll find
when a new feature is added there are tests added as well - this would
thus seemingly need a test adjustment as well.
</pre>
</blockquote>
<pre wrap="">Thanks John.
Will add tests.
</pre>
</blockquote>
<pre wrap="">
Adding such test usually means you go to tests/cputestdata/ directory
and run "./cpu-gather.sh | ./cpu-parse.sh" which will produce several
data files. Then you add a new test case in tests/cputest.c for this new
CPU and regenerate the files with expected results. If you do this
before adding the new feature, the patch which will then add it will
nicely show the new feature gets added into the expected results of the
new CPU test.
Don't forget to install cpuid tool and make sure you have the latest
upstream qemu installed in the system.
Jirka
</pre>
</blockquote>
<p class="MsoNormal"><span style="font-size:10.5pt" lang="EN-US">Hi
Jirka,<br>
</span></p>
<p class="MsoNormal"><span style="font-size:10.5pt" lang="EN-US">I
went through the
</span><span lang="EN-US">tests/cputestdata/ directory and found
it’s for defining features for different CPU models.</span></p>
<p class="MsoNormal"><span lang="EN-US">However, the la57 feature is
not included in any current CPUs. So I think we can get waived
for the tests changes?</span><span style="font-size:10.5pt"
lang="EN-US"></span></p>
<p class="MsoNormal"
style="text-align:justify;text-justify:inter-ideograph"><span
style="font-size:10.5pt;mso-fareast-language:ZH-CN" lang="EN-US">I
</span><span style="font-size:10.5pt;mso-fareast-language:ZH-CN"
lang="EN-US"><span
style="font-size:10.5pt;mso-fareast-language:ZH-CN"
lang="EN-US">check la57</span> on my </span><span
style="font-size:10.5pt;mso-fareast-language:ZH-CN" lang="EN-US">Haswell
platform it show<br>
</span></p>
<p class="MsoNormal"
style="text-align:justify;text-justify:inter-ideograph"><span
style="font-size:10.5pt;mso-fareast-language:ZH-CN" lang="EN-US">$
qemu-system-x86_64 -enable-kvm -cpu Haswell,+la57,check<br>
warning: host doesn't support requested feature:
CPUID.07H:ECX.la57 [bit 16]<br>
<br>
</span></p>
BR<br>
<br>
Shaohe Feng<span style="font-size:10.5pt;mso-fareast-language:ZH-CN"
lang="EN-US"></span>
</body>
</html>