<div dir="ltr"><div style="font-size:12.8px">ping</div><div style="font-size:12.8px"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 30, 2017 at 6:04 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Thu, Nov 30, 2017 at 09:50:01AM +0800, Paul Schlacter wrote:<br>
> hello everyone:<br>
> In q35 motherboard use ide, Currently, the qemu has supported q35<br>
> Motherboard support ide bus<br>
<br>
</span>IIRC, this is not quite correct - q35 has a built-in SATA controller,<br>
as opposed to IDE controller. You can potentially add an IDE controller<br>
as an optional extra.<br>
<span><br>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c<br>
> index cc7596b..2dbade8 100644<br>
> --- a/src/qemu/qemu_domain.c<br>
> +++ b/src/qemu/qemu_domain.c<br>
> @@ -7188,6 +7188,7 @@ bool<br>
> qemuDomainMachineHasBuiltinIDE<wbr>(const char *machine)<br>
> {<br>
> return qemuDomainMachineIsI440FX(mach<wbr>ine) ||<br>
> + qemuDomainMachineIsQ35(machine<wbr>) ||<br>
> STREQ(machine, "malta") ||<br>
> STREQ(machine, "sun4u") ||<br>
> STREQ(machine, "g3beige");<br>
<br>
</span>I don't see an equivalent qemuDomainMachineHasBuiltinSAT<wbr>A method,<br>
so I wonder if there's any logic we're missing in this respect ?<br>
Perhaps Laine or someone more recenty familiar wit the code can<br>
comment...<br>
<br>
Regards,<br>
Daniel<br>
<span class="m_-3479037318636826299HOEnZb"><font color="#888888">--<br>
|: <a href="https://berrange.com" rel="noreferrer" target="_blank">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange" rel="noreferrer" target="_blank">https://www.flickr.com/photos/<wbr>dberrange</a> :|<br>
|: <a href="https://libvirt.org" rel="noreferrer" target="_blank">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com" rel="noreferrer" target="_blank">https://fstop138.berrange.com</a> :|<br>
|: <a href="https://entangle-photo.org" rel="noreferrer" target="_blank">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange" rel="noreferrer" target="_blank">https://www.instagram.com/dber<wbr>range</a> :|<br>
</font></span></blockquote></div><br></div></div>