<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">On 02/01/2018 10:35 PM, Paul Schlacter
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CADak6y6+hKtg+Ay1fmzGZ6+fRzyLTc_2AZhw4vdkhx6f+1vKvQ@mail.gmail.com">
      <div dir="ltr">
        <div style="font-size:12.8px">ping</div>
      </div>
    </blockquote>
    <br>
    Sorry, I missed this the first time through.<br>
    <br>
    <br>
    <blockquote type="cite"
cite="mid:CADak6y6+hKtg+Ay1fmzGZ6+fRzyLTc_2AZhw4vdkhx6f+1vKvQ@mail.gmail.com">
      <div dir="ltr">
        <div style="font-size:12.8px"><br>
        </div>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Thu, Nov 30, 2017 at 6:04 PM,
            Daniel P. Berrange <span dir="ltr"><<a
                href="mailto:berrange@redhat.com" target="_blank"
                moz-do-not-send="true">berrange@redhat.com</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On
                Thu, Nov 30, 2017 at 09:50:01AM +0800, Paul Schlacter
                wrote:<br>
                > hello everyone:<br>
                >     In q35 motherboard use ide,  Currently, the
                qemu has supported q35<br>
                > Motherboard support ide bus<br>
                <br>
              </span>IIRC, this is not quite correct - q35 has a
              built-in  SATA controller,<br>
              as opposed to IDE controller. You can potentially add an
              IDE controller<br>
              as an optional extra.<br>
            </blockquote>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    The first statement is true - Q35 has an integrated SATA controller,
    not an IDE. It happens that qemu has hardcoded the device id of the
    SATA controller to be "ide" (same as the IDE controller on other
    archs) which can make things confusing.<br>
    <br>
    The second statement (you can add an IDE controller as an optional
    extra) is true if you are creating the qemu commandline yourself
    (bypassing libvirt), but libvirt doesn't support additional IDE
    controllers on *any* arch/machinetype (not even 440fx). I had
    written a patch to do that a few years ago (not because someone
    requested it, but because when fixing sata controller support for
    Q35, I noticed that it was possible to add as many IDE controllers
    as you liked and libvirt would simply ignore them), but after
    discussion we decided that we didn't want to promote use of such an
    old, slow, controller when there are so many better ways to connect
    a disk.<br>
    <br>
    Is there a specific reason why you think you require an IDE
    controller on a Q35 virtual machine? Since this patch doesn't
    actually provide that, perhaps you simply need to connect your disk
    device to the sata controller.<br>
    <br>
    <br>
    <blockquote type="cite"
cite="mid:CADak6y6+hKtg+Ay1fmzGZ6+fRzyLTc_2AZhw4vdkhx6f+1vKvQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <span><br>
                > diff --git a/src/qemu/qemu_domain.c
                b/src/qemu/qemu_domain.c<br>
                > index cc7596b..2dbade8 100644<br>
                > --- a/src/qemu/qemu_domain.c<br>
                > +++ b/src/qemu/qemu_domain.c<br>
                > @@ -7188,6 +7188,7 @@ bool<br>
                >  qemuDomainMachineHasBuiltinIDE<wbr>(const char
                *machine)<br>
                >  {<br>
                >      return qemuDomainMachineIsI440FX(mach<wbr>ine)
                ||<br>
                > +        qemuDomainMachineIsQ35(machine<wbr>) ||<br>
                >          STREQ(machine, "malta") ||<br>
                >          STREQ(machine, "sun4u") ||<br>
                >          STREQ(machine, "g3beige");<br>
                <br>
              </span>I don't see an equivalent 
              qemuDomainMachineHasBuiltinSAT<wbr>A method,<br>
              so I wonder if there's any logic we're missing in this
              respect ?<br>
              Perhaps Laine or someone more recenty familiar wit the
              code can<br>
              comment...<br>
              <br>
              Regards,<br>
              Daniel<br>
              <span class="m_-3479037318636826299HOEnZb"><font
                  color="#888888">--<br>
                  |: <a href="https://berrange.com" rel="noreferrer"
                    target="_blank" moz-do-not-send="true">https://berrange.com</a> 
                      -o-    <a
                    href="https://www.flickr.com/photos/dberrange"
                    rel="noreferrer" target="_blank"
                    moz-do-not-send="true">https://www.flickr.com/photos/<wbr>dberrange</a>
                  :|<br>
                  |: <a href="https://libvirt.org" rel="noreferrer"
                    target="_blank" moz-do-not-send="true">https://libvirt.org</a> 
                         -o-            <a
                    href="https://fstop138.berrange.com"
                    rel="noreferrer" target="_blank"
                    moz-do-not-send="true">https://fstop138.berrange.com</a>
                  :|<br>
                  |: <a href="https://entangle-photo.org"
                    rel="noreferrer" target="_blank"
                    moz-do-not-send="true">https://entangle-photo.org</a> 
                    -o-    <a
                    href="https://www.instagram.com/dberrange"
                    rel="noreferrer" target="_blank"
                    moz-do-not-send="true">https://www.instagram.com/dber<wbr>range</a>
                  :|<br>
                </font></span></blockquote>
          </div>
          <br>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">--
libvir-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/libvir-list">https://www.redhat.com/mailman/listinfo/libvir-list</a></pre>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>