<div dir="ltr">On 18 April 2018 at 00:41, Cole Robinson <span dir="ltr"><<a href="mailto:crobinso@redhat.com" target="_blank">crobinso@redhat.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">On 04/17/2018 01:33 PM, John Ferlan wrote:<br>
> <br>
> <br>
> On 04/16/2018 06:56 PM, Sukrit Bhatnagar wrote:<br>
>> Changes in v4:<br>
>> Changes made in v2 anbd v3 to qemu_command.c are discarded.<br>
>> Some changes introduced in v2 are used to create new smaller patches.<br>
>> virQEMUBuildBufferEscapeComma was applied to:<br>
>> - info->romfile in qemuBuildRomStr<br>
>> - disk->vendor and disk->product in qemuBuildDriveDevStr<br>
>> - fs->src->path in qemuBuildFSStr<br>
>> - fs->dst in qemuBuildFSDevStr<br>
>> - cfg->vncTLSx509certdir in qemuBuildGraphicsVNCCommandLin<wbr>e<br>
>> - loader->path and loader->nvram in qemuBuildDomainLoaderCommandLi<wbr>ne<br>
>><br>
>><br>
>> Changes in v3:<br>
>> virQEMUBuildBufferEscapeComma was applied to:<br>
>> - src->hosts->socket in qemuBuildNetworkDriveURI<br>
>> - src->path, src->configFile in qemuBuildNetworkDriveStr<br>
>> - disk->blkdeviotune.group_name in qemuBuildDiskThrottling<br>
>> - net->data.socket.address, net->data.socket.localaddr in<br>
>>   qemuBuildHostNetStr<br>
>> - dev->data.file.path in qemuBuildChrChardevStr<br>
>> - graphics->data.spice.<wbr>rendernode in<br>
>>   qemuBuildGraphicsSPICECommandL<wbr>ine<br>
>> - smartcard->data.cert.file[i], smartcard->data.cert.database in<br>
>>   qemuBuildSmartcardCommandLine<br>
>><br>
>> Link to v3: <a href="https://www.redhat.com/archives/libvir-list/2018-April/msg00053.html" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>archives/libvir-list/2018-<wbr>April/msg00053.html</a><br>
>><br>
>> Changes in v2:<br>
>> virQEMUBuildBufferEscapeComma was applied to:<br>
>> - info->romfile in qemuBuildRomStr<br>
>> - disk->vendor, disk->product in qemuBuildDriveDevStr<br>
>> - fs->src->path in qemuBuildFSStr<br>
>> - fs->dst in qemuBuildFSDevStr<br>
>> - connect= in qemuBuildHostNetStr<br>
>> - fileval handling in qemuBuildChrChardevStr<br>
>> - TYPE_DEV, TYPE_PIPE handling in qemuBuildChrChardevStr<br>
>> - cfg->vncTLSx509certdir in qemuBuildGraphicsVNCCommandLin<wbr>e<br>
>> - cfg->spiceTLSx509certdir in qemuBuildGraphicsSPICECommandL<wbr>ine<br>
>> - loader->path, loader->nvram usage in<br>
>>   qemuBuildDomainLoaderCommandLi<wbr>ne<br>
>><br>
>> Link to v2: <a href="https://www.redhat.com/archives/libvir-list/2018-March/msg00965.html" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>archives/libvir-list/2018-<wbr>March/msg00965.html</a><br>
>><br>
>><br>
>> Sukrit Bhatnagar (5):<br>
>>   qemu: Escape commas for qemuBuildRomStr<br>
>>   qemu: Escape commas for qemuBuildDriveDevStr<br>
>>   qemu: Escape commas for qemuBuildFSStr and qemuBuildFSDevStr<br>
>>   qemu: Escape commas for qemuBuildGraphicsVNCCommandLin<wbr>e<br>
>>   qemu: Escape commas for qemuBuildDomainLoaderCommandLi<wbr>ne<br>
>><br>
>>  src/qemu/qemu_command.c | 47 +++++++++++++++++++++++++++++-<wbr>-----------------<br>
>>  1 file changed, 29 insertions(+), 18 deletions(-)<br>
>><br>
> <br>
> Reviewed-by: John Ferlan <<a href="mailto:jferlan@redhat.com">jferlan@redhat.com</a>><br>
> (series) and pushed.<br>
> <br>
> Congrats on your first libvirt patches,<br>
> <br>
> John<br>
<br>
</div></div>Since I'm guessing these patches were motivated by the BiteSizedTasks<br>
entry, I updated the list there:<br>
<br>
<a href="https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values" rel="noreferrer" target="_blank">https://wiki.libvirt.org/page/<wbr>BiteSizedTasks#qemu:_Use_<wbr>comma_escaping_for_more_<wbr>command_line_values</a><br>
<br>
Sukrit if you hit issues with any of the other entries please let me<br>
know, maybe some of them aren't adequately described<br></blockquote><div><br></div><div>I had earlier tried the conversion to virConfGetValue* functions listed in Code Cleanup tasks.</div><div>I had a few issues there:</div><div>- in the enum virConfType, there no value for Int and UInt.</div><div>- in the function virConfGetValueInt and virConfGetValueUInt, </div><div>  the value is checked for types LLong and ULLong, which would</div><div>  always result in an error.</div><div><br></div><div>I think maybe some datatypes need to be added to the virConfType and</div><div>appropriate type must be assigned in virConfValue.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
> <br>
> BTW: All your patches appeared as would a reply-to in the series, I<br>
> think that may be because of not using --no-chain-reply-to on the git<br>
> send-email or git format-patch command line.<br>
> <br>
<br>
</span>In my ~/.gitconfig I have:<br>
<br>
[sendemail]<br>
    chainreplyto = false<br>
<br>
<br>
Thanks,<br>
Cole<br>
</blockquote></div><br></div></div>