<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 09/10/2018 02:55 PM, Chen Hanxiao
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:11097337.64fb.165c243506b.Coremail.chen_han_xiao@126.com">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<pre>
At 2018-09-07 18:44:53, "Lin Ma" <a class="moz-txt-link-rfc2396E" href="mailto:lma@suse.com"><lma@suse.com></a> wrote:
>When we call qemuARPGetInterfaces to get IP from host's arp table, The
>iface's type has nothing to do with it, We should allow all of type.
>
>Signed-off-by: Lin Ma <a class="moz-txt-link-rfc2396E" href="mailto:lma@suse.com"><lma@suse.com></a>
<div>Hi,</div><div> with my limited tests, </div><div> we can't get useful info by arp query from other kind of interface types.</div></pre>
</div>
</blockquote>
<br>
<tt>IMO, As long as the host interface and the guest interface
communicated</tt><tt><br>
</tt><tt>through osi layer3 or above, Host kernel will maintaince
the corresponding<br>
ip <-> mac</tt><tt> entry in arp able.</tt><tt><br>
</tt><tt><br>
</tt><tt>What you mentioned above remind me one thing: I forgot to
mention that</tt><tt><br>
</tt><tt>if the switch doesn't support hairpin mode, then</tt><tt> </tt><tt>the
virtual interfaces</tt><tt><br>
</tt><tt>which backend is mactap can't communicate with</tt><tt> </tt><tt>host,
that means the host</tt><tt><br>
</tt><tt>arp table won't include the ip <-> </tt><tt>mac </tt><tt>information
of such</tt><tt> virtual interfaces.</tt><tt><br>
</tt><tt>In</tt><tt> </tt><tt>this case, the qemuARPGetInterfaces
can't get IP.</tt><tt><br>
</tt><tt><br>
</tt><tt>So I'd like to change the code to only ignore
VIR_DOMAIN_NET_TYPE_DIRECT</tt><tt><br>
</tt><tt>in patch V2, For any</tt><tt>else</tt><tt> net types, the
code will iterate the arp table for</tt><tt><br>
</tt><tt>loop</tt><tt> </tt><tt>to try to search if there is a
matched entry.</tt><tt><br>
</tt><tt><br>
</tt><tt>what do you think?</tt><tt><br>
</tt><tt><br>
</tt><tt>Thanks,</tt><tt><br>
</tt><tt>Lin</tt>
</body>
</html>