<div dir="ltr">Pavel,<br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina <span dir="ltr"><<a href="mailto:phrdina@redhat.com" target="_blank">phrdina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Pavel Hrdina (9):<br>
vircgroup: cleanup controllers not managed by systemd on error<br>
vircgroup: fix bug in virCgroupEnableMissingControll<wbr>ers<br>
vircgroup: rename virCgroupAdd.*Task to virCgroupAdd.*Process<br>
vircgroup: introduce virCgroupTaskFlags<br>
vircgroup: introduce virCgroupAddThread<br>
vircgroupmock: cleanup unused cgroup files<br>
vircgroupmock: rewrite cgroup fopen mocking<br>
vircgrouptest: call virCgroupDetectMounts directly<br>
vircgrouptest: call virCgroupNewSelf instead virCgroupDetectMounts<br>
<br>
src/libvirt-lxc.c | 2 +-<br>
src/libvirt_private.syms | 6 +-<br>
src/lxc/lxc_controller.c | 4 +-<br>
src/qemu/qemu_process.c | 4 +-<br>
src/qemu/qemu_tpm.c | 2 +-<br>
src/util/vircgroup.c | 135 +++++++-----<br>
src/util/vircgroup.h | 5 +-<br>
src/util/vircgrouppriv.h | 4 -<br>
tests/vircgroupdata/all-in-<wbr>one.cgroups | 7 +<br>
tests/vircgroupdata/all-in-<wbr>one.mounts | 2 +-<br>
tests/vircgroupdata/all-in-<wbr>one.parsed | 12 +-<br>
tests/vircgroupdata/all-in-<wbr>one.self.cgroup | 1 +<br>
tests/vircgroupdata/cgroups1.<wbr>cgroups | 11 +<br>
tests/vircgroupdata/cgroups1.<wbr>self.cgroup | 11 +<br>
tests/vircgroupdata/cgroups2.<wbr>cgroups | 10 +<br>
tests/vircgroupdata/cgroups2.<wbr>self.cgroup | 10 +<br>
tests/vircgroupdata/cgroups3.<wbr>cgroups | 12 +<br>
tests/vircgroupdata/cgroups3.<wbr>self.cgroup | 12 +<br>
tests/vircgroupdata/fedora-18.<wbr>cgroups | 10 +<br>
tests/vircgroupdata/fedora-18.<wbr>self.cgroup | 9 +<br>
tests/vircgroupdata/fedora-21.<wbr>cgroups | 12 +<br>
tests/vircgroupdata/fedora-21.<wbr>self.cgroup | 10 +<br>
tests/vircgroupdata/kubevirt.<wbr>cgroups | 10 +<br>
tests/vircgroupdata/kubevirt.<wbr>self.cgroup | 10 +<br>
tests/vircgroupdata/logind.<wbr>cgroups | 10 +<br>
tests/vircgroupdata/logind.<wbr>mounts | 2 +<br>
tests/vircgroupdata/logind.<wbr>self.cgroup | 1 +<br>
tests/vircgroupdata/ovirt-<wbr>node-6.6.cgroups | 9 +<br>
.../vircgroupdata/ovirt-node-<wbr>6.6.self.cgroup | 8 +<br>
tests/vircgroupdata/ovirt-<wbr>node-7.1.cgroups | 11 +<br>
.../vircgroupdata/ovirt-node-<wbr>7.1.self.cgroup | 10 +<br>
tests/vircgroupdata/rhel-7.1.<wbr>cgroups | 11 +<br>
tests/vircgroupdata/rhel-7.1.<wbr>self.cgroup | 10 +<br>
tests/vircgroupdata/systemd.<wbr>cgroups | 8 +<br>
tests/vircgroupdata/systemd.<wbr>mounts | 11 +<br>
tests/vircgroupdata/systemd.<wbr>self.cgroup | 6 +<br>
tests/vircgroupmock.c | 206 ++----------------<br>
tests/vircgrouptest.c | 24 +-<br>
38 files changed, 362 insertions(+), 276 deletions(-)<br>
create mode 100644 tests/vircgroupdata/all-in-<wbr>one.cgroups<br>
create mode 100644 tests/vircgroupdata/all-in-<wbr>one.self.cgroup<br>
create mode 100644 tests/vircgroupdata/cgroups1.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/cgroups1.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/cgroups2.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/cgroups2.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/cgroups3.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/cgroups3.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/fedora-18.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/fedora-18.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/fedora-21.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/fedora-21.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/kubevirt.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/kubevirt.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/logind.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/logind.<wbr>mounts<br>
create mode 100644 tests/vircgroupdata/logind.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/ovirt-<wbr>node-6.6.cgroups<br>
create mode 100644 tests/vircgroupdata/ovirt-<wbr>node-6.6.self.cgroup<br>
create mode 100644 tests/vircgroupdata/ovirt-<wbr>node-7.1.cgroups<br>
create mode 100644 tests/vircgroupdata/ovirt-<wbr>node-7.1.self.cgroup<br>
create mode 100644 tests/vircgroupdata/rhel-7.1.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/rhel-7.1.<wbr>self.cgroup<br>
create mode 100644 tests/vircgroupdata/systemd.<wbr>cgroups<br>
create mode 100644 tests/vircgroupdata/systemd.<wbr>mounts<br>
create mode 100644 tests/vircgroupdata/systemd.<wbr>self.cgroup<br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
2.17.1<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/libvir-list</a><br>
</font></span></blockquote></div></div><div class="gmail_extra"><br></div><div class="gmail_extra">I went through your series and the patches are mostly looking there.</div><div class="gmail_extra">There are a few comments in the series related to some typos and an actual problem in the last patch.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Please, do *not* push the reviewed patches already as I'd give them the chance to be reviewed by someone who's more experienced with this piece of code.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Let me know when you submit a v2 and I'll just check the 9th patch.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Best Regards,</div><div class="gmail_extra">--</div><div class="gmail_extra">Fabiano Fidêncio<br></div></div></div></div>