<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina <span dir="ltr"><<a href="mailto:phrdina@redhat.com" target="_blank">phrdina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Pavel Hrdina <<a href="mailto:phrdina@redhat.com" target="_blank">phrdina@redhat.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Fabiano Fidêncio <<a href="mailto:fidencio@redhat.com" target="_blank">fidencio@redhat.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
 src/util/vircgroup.c        | 22 +---------------------<br>
 src/util/vircgroupbackend.h |  7 +++++++<br>
 src/util/vircgroupv1.c      | 31 ++++++++++++++++++++++++++++++<wbr>+<br>
 3 files changed, 39 insertions(+), 21 deletions(-)<br>
<br>
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c<br>
index 817ee8f6ca..55122a5ab9 100644<br>
--- a/src/util/vircgroup.c<br>
+++ b/src/util/vircgroup.c<br>
@@ -1454,27 +1454,7 @@ virCgroupPathOfController(virC<wbr>groupPtr group,<br>
         return -1;<br>
     }<br>
<br>
-    if (group->controllers[controller<wbr>].mountPoint == NULL) {<br>
-        virReportError(VIR_ERR_INTERNA<wbr>L_ERROR,<br>
-                       _("Controller '%s' is not mounted"),<br>
-                       <wbr>virCgroupControllerTypeToStrin<wbr>g(controller));<br>
-        return -1;<br>
-    }<br>
-<br>
-    if (group->controllers[controller<wbr>].placement == NULL) {<br>
-        virReportError(VIR_ERR_INTERNA<wbr>L_ERROR,<br>
-                       _("Controller '%s' is not enabled for group"),<br>
-                       <wbr>virCgroupControllerTypeToStrin<wbr>g(controller));<br>
-        return -1;<br>
-    }<br>
-<br>
-    if (virAsprintf(path, "%s%s/%s",<br>
-                    group->controllers[controller]<wbr>.mountPoint,<br>
-                    group->controllers[controller]<wbr>.placement,<br>
-                    key ? key : "") < 0)<br>
-        return -1;<br>
-<br>
-    return 0;<br>
+    return group->backend->pathOfControll<wbr>er(group, controller, key, path);<br>
 }<br>
<br>
<br>
diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h<br>
index 933f59151a..cf000529c4 100644<br>
--- a/src/util/vircgroupbackend.h<br>
+++ b/src/util/vircgroupbackend.h<br>
@@ -80,6 +80,12 @@ typedef bool<br>
 typedef int<br>
 (*<wbr>virCgroupGetAnyControllerCB)(<wbr>virCgroupPtr group);<br>
<br>
+typedef int<br>
+(*virCgroupPathOfControllerCB<wbr>)(virCgroupPtr group,<br>
+                               int controller,<br>
+                               const char *key,<br>
+                               char **path);<br>
+<br>
 struct _virCgroupBackend {<br>
     virCgroupBackendType type;<br>
<br>
@@ -95,6 +101,7 @@ struct _virCgroupBackend {<br>
     virCgroupDetectControllersCB detectControllers;<br>
     virCgroupHasControllerCB hasController;<br>
     virCgroupGetAnyControllerCB getAnyController;<br>
+    virCgroupPathOfControllerCB pathOfController;<br>
 };<br>
 typedef struct _virCgroupBackend virCgroupBackend;<br>
 typedef virCgroupBackend *virCgroupBackendPtr;<br>
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c<br>
index 105024ddde..7d92150dc3 100644<br>
--- a/src/util/vircgroupv1.c<br>
+++ b/src/util/vircgroupv1.c<br>
@@ -506,6 +506,36 @@ virCgroupV1GetAnyController(vi<wbr>rCgroupPtr group)<br>
 }<br>
<br>
<br>
+static int<br>
+virCgroupV1PathOfController(v<wbr>irCgroupPtr group,<br>
+                            int controller,<br>
+                            const char *key,<br>
+                            char **path)<br>
+{<br>
+    if (group->controllers[controller<wbr>].mountPoint == NULL) {<br>
+        virReportError(VIR_ERR_INTERNA<wbr>L_ERROR,<br>
+                       _("v1 controller '%s' is not mounted"),<br>
+                       <wbr>virCgroupV1ControllerTypeToStr<wbr>ing(controller));<br>
+        return -1;<br>
+    }<br>
+<br>
+    if (group->controllers[controller<wbr>].placement == NULL) {<br>
+        virReportError(VIR_ERR_INTERNA<wbr>L_ERROR,<br>
+                       _("v1 controller '%s' is not enabled for group"),<br>
+                       <wbr>virCgroupV1ControllerTypeToStr<wbr>ing(controller));<br>
+        return -1;<br>
+    }<br>
+<br>
+    if (virAsprintf(path, "%s%s/%s",<br>
+                    group->controllers[controller]<wbr>.mountPoint,<br>
+                    group->controllers[controller]<wbr>.placement,<br>
+                    key ? key : "") < 0)<br>
+        return -1;<br>
+<br>
+    return 0;<br>
+}<br>
+<br>
+<br>
 virCgroupBackend virCgroupV1Backend = {<br>
     .type = VIR_CGROUP_BACKEND_TYPE_V1,<br>
<br>
@@ -520,6 +550,7 @@ virCgroupBackend virCgroupV1Backend = {<br>
     .detectControllers = virCgroupV1DetectControllers,<br>
     .hasController = virCgroupV1HasController,<br>
     .getAnyController = virCgroupV1GetAnyController,<br>
+    .pathOfController = virCgroupV1PathOfController,<br>
 };<br>
<span class="m_1646940007787780647HOEnZb"><font color="#888888"> <br>
<br>
-- <br>
2.17.1<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/libvir-list</a><br>
</font></span></blockquote></div><br></div></div>