<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina <span dir="ltr"><<a href="mailto:phrdina@redhat.com" target="_blank">phrdina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Pavel Hrdina <<a href="mailto:phrdina@redhat.com" target="_blank">phrdina@redhat.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Fabiano Fidêncio <<a href="mailto:fidencio@redhat.com" target="_blank">fidencio@redhat.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/util/vircgroup.c | 13 +------------<br>
src/util/vircgroupbackend.h | 5 +++++<br>
src/util/vircgroupv1.c | 20 ++++++++++++++++++++<br>
3 files changed, 26 insertions(+), 12 deletions(-)<br>
<br>
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c<br>
index 5dd736930b..f5ae23836f 100644<br>
--- a/src/util/vircgroup.c<br>
+++ b/src/util/vircgroup.c<br>
@@ -3467,18 +3467,7 @@ virCgroupSupportsCpuBW(virCgro<wbr>upPtr cgroup)<br>
int<br>
virCgroupHasEmptyTasks(virCgr<wbr>oupPtr cgroup, int controller)<br>
{<br>
- int ret = -1;<br>
- VIR_AUTOFREE(char *) content = NULL;<br>
-<br>
- if (!cgroup)<br>
- return -1;<br>
-<br>
- ret = virCgroupGetValueStr(cgroup, controller, "tasks", &content);<br>
-<br>
- if (ret == 0 && content[0] == '\0')<br>
- ret = 1;<br>
-<br>
- return ret;<br>
+ return cgroup->backend->hasEmptyTasks<wbr>(cgroup, controller);<br>
}<br>
<br>
bool<br>
diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h<br>
index 4661d82132..1964a48ff0 100644<br>
--- a/src/util/vircgroupbackend.h<br>
+++ b/src/util/vircgroupbackend.h<br>
@@ -114,6 +114,10 @@ typedef int<br>
pid_t pid,<br>
unsigned int flags);<br>
<br>
+typedef int<br>
+(*virCgroupHasEmptyTasksCB)(v<wbr>irCgroupPtr cgroup,<br>
+ int controller);<br>
+<br>
struct _virCgroupBackend {<br>
virCgroupBackendType type;<br>
<br>
@@ -133,6 +137,7 @@ struct _virCgroupBackend {<br>
virCgroupMakeGroupCB makeGroup;<br>
virCgroupRemoveCB remove;<br>
virCgroupAddTaskCB addTask;<br>
+ virCgroupHasEmptyTasksCB hasEmptyTasks;<br>
};<br>
typedef struct _virCgroupBackend virCgroupBackend;<br>
typedef virCgroupBackend *virCgroupBackendPtr;<br>
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c<br>
index c9f6fd925a..57bcb6a685 100644<br>
--- a/src/util/vircgroupv1.c<br>
+++ b/src/util/vircgroupv1.c<br>
@@ -735,6 +735,25 @@ virCgroupV1AddTask(virCgroupPt<wbr>r group,<br>
}<br>
<br>
<br>
+static int<br>
+virCgroupV1HasEmptyTasks(virC<wbr>groupPtr cgroup,<br>
+ int controller)<br>
+{<br>
+ int ret = -1;<br>
+ VIR_AUTOFREE(char *) content = NULL;<br>
+<br>
+ if (!cgroup)<br>
+ return -1;<br>
+<br>
+ ret = virCgroupGetValueStr(cgroup, controller, "tasks", &content);<br>
+<br>
+ if (ret == 0 && content[0] == '\0')<br>
+ ret = 1;<br>
+<br>
+ return ret;<br>
+}<br>
+<br>
+<br>
virCgroupBackend virCgroupV1Backend = {<br>
.type = VIR_CGROUP_BACKEND_TYPE_V1,<br>
<br>
@@ -753,6 +772,7 @@ virCgroupBackend virCgroupV1Backend = {<br>
.makeGroup = virCgroupV1MakeGroup,<br>
.remove = virCgroupV1Remove,<br>
.addTask = virCgroupV1AddTask,<br>
+ .hasEmptyTasks = virCgroupV1HasEmptyTasks,<br>
};<br>
<span class="m_-4425048271582880447HOEnZb"><font color="#888888"> <br>
<br>
-- <br>
2.17.1<br>
<br>
--<br>
libvir-list mailing list<br>
<a href="mailto:libvir-list@redhat.com" target="_blank">libvir-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/libvir-list</a><br>
</font></span></blockquote></div><br></div></div>