<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 6, 2018 at 6:34 AM John Ferlan <<a href="mailto:jferlan@redhat.com">jferlan@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">$SUBJ:<br>
<br>
s/implement/Implement<br>
<br>
On 10/12/18 4:50 AM, Han Han wrote:<br>
> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1375423" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1375423</a><br>
<br>
Add the infrastructure to allow a USB Hub device to be hotplugged.<br>
<br>
> <br>
> Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>><br>
> ---<br>
>  src/qemu/qemu_driver.c  |  9 ++++++-<br>
>  src/qemu/qemu_hotplug.c | 58 +++++++++++++++++++++++++++++++++++++++++<br>
>  src/qemu/qemu_hotplug.h |  8 ++++++<br>
>  3 files changed, 74 insertions(+), 1 deletion(-)<br>
> <br>
<br>
[...]<br>
<br>
> diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h<br>
> index 0297e42a98..444333c4df 100644<br>
> --- a/src/qemu/qemu_hotplug.h<br>
> +++ b/src/qemu/qemu_hotplug.h<br>
> @@ -135,10 +135,18 @@ int qemuDomainAttachInputDevice(virQEMUDriverPtr driver,<br>
>                                  virDomainObjPtr vm,<br>
>                                  virDomainInputDefPtr input);<br>
>  <br>
> +int qemuDomainAttachHubDevice(virQEMUDriverPtr driver,<br>
> +                          virDomainObjPtr vm,<br>
> +                          virDomainHubDefPtr hub);<br>
> +<br>
>  int qemuDomainAttachVsockDevice(virQEMUDriverPtr driver,<br>
>                                  virDomainObjPtr vm,<br>
>                                  virDomainVsockDefPtr vsock);<br>
>  <br>
> +int qemuDomainAttachInputDevice(virQEMUDriverPtr driver,<br>
> +                                virDomainObjPtr vm,<br>
> +                                virDomainInputDefPtr input);<br>
> +<br>
<br>
cut-n-paste error perhaps? I'll remove before pushing though...<br></blockquote><div>Sorry for the silly mistake... I will remove it in new patch series. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Reviewed-by: John Ferlan <<a href="mailto:jferlan@redhat.com" target="_blank">jferlan@redhat.com</a>><br>
<br>
John<br>
<br>
<br>
>  int qemuDomainAttachLease(virQEMUDriverPtr driver,<br>
>                            virDomainObjPtr vm,<br>
>                            virDomainLeaseDefPtr lease);<br>
> <br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div>