<div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)"><span style="color:rgb(34,34,34)">On Mon, Jan 28, 2019 at 6:13 PM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote:</span><br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Jan 28, 2019 at 04:37:50PM +0100, Kevin Wolf wrote:<br>
> Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben:<br>
> > This option is broken since a6baa60807 in v2.9 and returns mostly<br>
> > zeroes instead of real stats because actual querring of BlockStats<br>
> > that resides in blk is missing.<br>
> > <br>
> > And it makes no sense because with this option BlockDriverState-s<br>
> > are iterated but BlockAcctStats belong to BlockBackend and not BDS<br>
> > since 7f0e9da6f13 in v2.5<br>
> > <br>
> > Signed-off-by: Anton Kuchin <<a href="mailto:antonkuchin@yandex-team.ru" target="_blank">antonkuchin@yandex-team.ru</a>><br>
> <br>
> Isn't query-nodes the only way to get wr_highest_offset for the protocol<br>
> layer? oVirt depends on this, as far as I know.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)">We do, thanks for caring!</div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Libvirt just invokes 'query-blockstats' with no arguments, so is not<br>
relying on 'query-nodes' working. Given that libvirt doesn't use it,<br>
it doesn't seem like this is relevant for oVirt unless they were<br>
using QMP passthrough from libvirt. </blockquote><div><br></div><div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)">We don't use QMP passthrough. We use only libvirt public APIs.</div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)">You can see what we use here:</div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)"><a href="https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/drivemonitor.py">https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/drivemonitor.py</a></div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-size:small;color:rgb(0,0,0)">Nir</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">That this has been broken<br>
since v2.9 though rather suggests oVirt doesn't use it.<br>
<br>
Regards,<br>
Daniel<br>
-- <br>
|: <a href="https://berrange.com" rel="noreferrer" target="_blank">https://berrange.com</a>      -o-    <a href="https://www.flickr.com/photos/dberrange" rel="noreferrer" target="_blank">https://www.flickr.com/photos/dberrange</a> :|<br>
|: <a href="https://libvirt.org" rel="noreferrer" target="_blank">https://libvirt.org</a>         -o-            <a href="https://fstop138.berrange.com" rel="noreferrer" target="_blank">https://fstop138.berrange.com</a> :|<br>
|: <a href="https://entangle-photo.org" rel="noreferrer" target="_blank">https://entangle-photo.org</a>    -o-    <a href="https://www.instagram.com/dberrange" rel="noreferrer" target="_blank">https://www.instagram.com/dberrange</a> :|<br>
</blockquote></div></div></div>