<div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 4, 2019 at 5:16 AM Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">*native in the subject<br>
<br>
On 3/28/19 1:57 AM, Han Han wrote:<br>
> Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>><br>
> ---<br>
>  src/vmware/vmware_conf.c   | 2 +-<br>
>  src/vmware/vmware_driver.c | 2 +-<br>
>  2 files changed, 2 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c<br>
> index 0c1b1f9550..76645a2e0d 100644<br>
> --- a/src/vmware/vmware_conf.c<br>
> +++ b/src/vmware/vmware_conf.c<br>
> @@ -285,7 +285,7 @@ vmwareExtractVersion(struct vmware_driver *driver)<br>
>              break;<br>
>  <br>
>          case VMWARE_DRIVER_FUSION:<br>
> -            if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx") < 0)<br>
> +            if (virAsprintf(&bin, "%s/%s", vmwarePath, VMX_CONFIG_FORMAT_ARGV) < 0)<br>
>                  goto cleanup;<br>
>              break;<br>
>  <br>
<br>
This usage is building a binary path like /usr/bin/vmware-vmx, so<br>
despite the strings being the same it's not the same type of usage. It<br>
shouldn't be replaced IMO<br>
<br>
Otherwise this series change makes sense, it's the same pattern used in<br>
other drivers. I suggest squashing it down to one patch though and send a v2<br>
<br></blockquote><div>Thanks for review. v2 link: <a href="https://www.redhat.com/archives/libvir-list/2019-April/msg00609.html">https://www.redhat.com/archives/libvir-list/2019-April/msg00609.html</a> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Thanks,<br>
Cole<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div></div>