<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 12, 2019 at 5:15 PM Markus Armbruster <<a href="mailto:armbru@redhat.com">armbru@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I apologize for my slooow response; KVM Forum happened.<br></blockquote><div>It doesn't matter. I attended KVM forum, too :)<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div> <br> Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>> writes:<br> <br> > On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik <<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>><br> > wrote:<br> ><br> >> On 10/15/19 7:23 AM, Han Han wrote:<br> >> > Hi Michal,<br> >> > Any more advice update?<br> >><br> >> Well, as I've said earlier, since we document that -1 is accepted value<br> >> and it means that it suppresses automatic reboots we need a way to<br> >> preserve this behaviour. For instance, what happens if you don't put<br> >> reboot-timeout onto the cmd line at all? Does qemu use some default and<br> >><br> > If no reboot-timeout, qemu will not reboot by default. I have updated the<br> > qemu doc:<br> > <a href="https://github.com/qemu/qemu/commit/bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8" rel="noreferrer" target="_blank">https://github.com/qemu/qemu/commit/bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8</a><br> <br> Since your message, upstream QEMU got this:<br> <br> commit 20a192203222efde055df688cc344f9efb87c372<br> Author: Dr. David Alan Gilbert <<a href="mailto:dgilbert@redhat.com" target="_blank">dgilbert@redhat.com</a>><br> Date: Fri Oct 25 17:57:06 2019 +0100<br> <br> fw_cfg: Allow reboot-timeout=-1 again<br> <br> Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout<br> to only allow the range 0..65535; however both qemu and libvirt document<br> the special value -1 to mean don't reboot.<br> Allow it again.<br> <br> Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout error checking")<br> RH bz: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1765443" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1765443</a><br> Signed-off-by: Dr. David Alan Gilbert <<a href="mailto:dgilbert@redhat.com" target="_blank">dgilbert@redhat.com</a>><br> Message-Id: <<a href="mailto:20191025165706.177653-1-dgilbert@redhat.com" target="_blank">20191025165706.177653-1-dgilbert@redhat.com</a>><br> Suggested-by: Laszlo Ersek <<a href="mailto:lersek@redhat.com" target="_blank">lersek@redhat.com</a>><br> Message-Id: <<a href="mailto:37ac197c-f20e-dd05-ff6a-13a2171c7148@redhat.com" target="_blank">37ac197c-f20e-dd05-ff6a-13a2171c7148@redhat.com</a>><br> [PMD: Applied Laszlo's suggestions]<br> Reviewed-by: Laszlo Ersek <<a href="mailto:lersek@redhat.com" target="_blank">lersek@redhat.com</a>><br> Signed-off-by: Philippe Mathieu-Daudé <<a href="mailto:philmd@redhat.com" target="_blank">philmd@redhat.com</a>><br> <br> Commit bbd9e6985f "qemu-options.hx: Update for reboot-timeout parameter"<br> could be reverted now. Rewriting the parapgraph for clarity would be<br> better, though.<br></div><br></blockquote><div>Agree <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div> <br> >> reboot anyways? If it doesn't reboot then -1 should mean to not put<br> >><br> > I think they use the same defaults and will not reboot by default. That can<br> > be checked by<br> > the code before and after qemu commit ee5d0f8. The values passed to<br> > fw_cfg_add_file are<br> > same by default.<br> ><br> > Markus Armbruster,<br> > Could you please confirm that, for cases of<br> > - reboot-timeout=-1 before ee5d0f8<br> > - reboot-timeout by default before ee5d0f8<br> > - reboot-timeout by default after ee5d0f8<br> > they all will not reboot?<br> <br> Is this still necessary now that reboot-timeout=-1 has been fixed in<br> upstream QEMU?<br></div></blockquote><div>It is not necessary to introduce change to libvirt in reboot-timeout now.</div><div>BTW, the default value of reboot-timeout is -1, right?<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div> <br> >> reboot-timeout onto the cmd line. However, if it does reboot then we<br> >> need to talk to qemu developers to provide us a way to suppress<br> >> automatic reboots.<br> <br> </div></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div>