<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hi Han, Thanks for your kind reminder. I haven't used the 'virsh dommemstat' command for reporting the domain vcpus' memory bandwidth usage over host. What I implemented is add a new option '--memory' under command 'virsh domstats'. Reason for such kind of implementation is I haven't realized there is already one interface, the 'dommemstat' command, with the intention of showing domain memory related statistics. But after examining the ways to report the block device statistics, and the network traffic statistics, I found they are similar, for example you can find block device statistics from command 'virsh domblkstat' and 'virsh domstats --block'. So I tent to use the way that I have done in patch '1/5' to let these memory information be shown in command 'virsh domstasts --memory'. Reason is the memory bandwidth information is associated with the memory bandwidth monitor (a hardware feature from cpu manufacture), and each monitor could be applied to one or some vcpus. This is much similar to the case of 'virsh domstats --interface' and 'virsh domstats --block'. I hope more reviewers involve this discussion. Thanks Huaqiang <div class="moz-cite-prefix">On 2019/11/14 下午2:43, Han Han wrote: </div> <blockquote type="cite" cite="mid:CAHjf+S_02Fwc2niHhY7EDHhqaaqjBxFT-91KPCMf_V=ETjGFtg@mail.gmail.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <div dir="ltr"> <div>Just a reminder that libvirt binds need to be updated after patches introduced.</div> <div>Refer to libvirt python and perl bindings:</div> <div>commit b0a7747 Author: Pavel Hrdina <<a href="mailto:phrdina@redhat.com" moz-do-not-send="true">phrdina@redhat.com</a>> Date: Fri Sep 20 11:14:35 2019 +0200 virDomainMemoryStats: include disk caches Introduced in libvirt 4.6.0 by commit <aee04655089>. Resolves: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1683516" moz-do-not-send="true">https://bugzilla.redhat.com/show_bug.cgi?id=1683516</a> Signed-off-by: Pavel Hrdina <<a href="mailto:phrdina@redhat.com" moz-do-not-send="true">phrdina@redhat.com</a>> Reviewed-by: Daniel P. Berrangé <<a href="mailto:berrange@redhat.com" moz-do-not-send="true">berrange@redhat.com</a>></div> <div> </div> <div>commit e562e58 Author: Daniel P. Berrangé <<a href="mailto:berrange@redhat.com" moz-do-not-send="true">berrange@redhat.com</a>> Date: Wed May 22 14:07:57 2019 +0100 Add new hugetlb memory stats constants Signed-off-by: Daniel P. Berrangé <<a href="mailto:berrange@redhat.com" moz-do-not-send="true">berrange@redhat.com</a>> </div> </div> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Wed, Nov 13, 2019 at 6:34 PM Wang Huaqiang <<a href="mailto:huaqiang.wang@intel.com" moz-do-not-send="true">huaqiang.wang@intel.com</a>> wrote: </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">RDT is the short for Intel Resource Director Technology, consists of four sub-technologies until now: -. CAT for cache allocation -. CMT for cache usage monitoring -. MBA for memory bandwidth allocation -. MBM for memory bandwidth usage monitoring The Linux kernel interface is 'resctrl' file system, and we have already implemented the support of CAT, CMT and MBA, to accomplish the tasks such as allocating a part of shared CPU last level cache to particular domain vcpu or a list of vcpus and monitoring the usage of cache, or the task of allocating a mount of memory bandwidth to specify domain vcpu(s). This series is to introduce the support of MBM. Basically the interfaces are: ** Identify host capability ** Similar to identify the host capability of CMT, it could be gotten through the result of 'virsh capabilities', if following elements are found, then MBM is supported: <memory_bandwidth> <monitor maxMonitors='176'> <feature name='mbm_total_bytes'/> <feature name='mbm_local_bytes'/> </monitor> </memory_bandwidth> 'mbm_total_bytes' means supporting to report the memory bandwidth used by the vcpu(s) of specific monitor on all CPU sockets. 'mbm_local_bytes' means supporting to report the memory bandwidth used by vcpu(s) that is passing through local CPU socket. ** Create monitor group** The monitor group for specific domain vcpus, for example vcpu 0-4, is defined in domain configuration file, in such kind of way: <cputune> <memorytune vcpus='0-4'> <monitor vcpus='0-4'/> </memorytune> </cputune> ** Report memory usage ** Introduced an option '--memory' against 'virsh domstats' command to show the memory bandwidth usage in such way: (also very similar to the format of CMT result.) # virsh domstats --memory Domain: 'libvirt-vm' memory.bandwidth.monitor.count=4 <a href="http://memory.bandwidth.monitor.0.name" rel="noreferrer" target="_blank" moz-do-not-send="true">memory.bandwidth.monitor.0.name</a>=vcpus_0-4 memory.bandwidth.monitor.0.vcpus=0-4 memory.bandwidth.monitor.0.node.count=2 <a href="http://memory.bandwidth.monitor.0.node.0.id" rel="noreferrer" target="_blank" moz-do-not-send="true">memory.bandwidth.monitor.0.node.0.id</a>=0 memory.bandwidth.monitor.0.node.0.bytes.total=14201651200 memory.bandwidth.monitor.0.node.0.bytes.local=7369809920 <a href="http://memory.bandwidth.monitor.0.node.1.id" rel="noreferrer" target="_blank" moz-do-not-send="true">memory.bandwidth.monitor.0.node.1.id</a>=1 memory.bandwidth.monitor.0.node.1.bytes.total=188897640448 memory.bandwidth.monitor.0.node.1.bytes.local=170044047360 Huaqiang (5): util, resctrl: using 64bit interface instead of 32bit for counters conf: showing cache/memoryBW monitor features in capabilities cachetune schema: a looser check for the order of <cache> and <monitor> element conf: Parse dommon configure file for memorytune monitors virsh: show memoryBW info in 'virsh domstats' command docs/schemas/domaincommon.rng | 91 +++++++++--------- include/libvirt/libvirt-domain.h | 1 + src/conf/capabilities.c | 4 +- src/conf/domain_conf.c | 44 +++++++-- src/libvirt-domain.c | 21 +++++ src/qemu/qemu_driver.c | 103 ++++++++++++++++++++- src/util/virfile.c | 40 ++++++++ src/util/virfile.h | 2 + src/util/virresctrl.c | 6 +- src/util/virresctrl.h | 2 +- tests/genericxml2xmlindata/cachetune.xml | 1 + tests/genericxml2xmlindata/memorytune.xml | 5 + tests/genericxml2xmloutdata/cachetune.xml | 34 +++++++ tests/genericxml2xmloutdata/memorytune.xml | 42 +++++++++ tests/genericxml2xmltest.c | 4 +- tools/virsh-domain-monitor.c | 7 ++ tools/virsh.pod | 23 ++++- 17 files changed, 367 insertions(+), 63 deletions(-) create mode 100644 tests/genericxml2xmloutdata/cachetune.xml create mode 100644 tests/genericxml2xmloutdata/memorytune.xml -- 2.23.0 -- libvir-list mailing list <a href="mailto:libvir-list@redhat.com" target="_blank" moz-do-not-send="true">libvir-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/libvir-list" rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/libvir-list</a> </blockquote> </div> -- <div dir="ltr" class="gmail_signature"> <div dir="ltr"> <div> <div dir="ltr"> <div> <div dir="ltr">Best regards,</div> <div dir="ltr">----------------------------------- </div> <div dir="ltr">Han Han Quality Engineer Redhat. Email: <a href="mailto:hhan@redhat.com" target="_blank" moz-do-not-send="true">hhan@redhat.com</a> Phone: +861065339333 </div> </div> </div> </div> </div> </div> </blockquote> </body> </html>