<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">
Thanks. I have sent a patch based off the tip here:
<div><a href="https://www.redhat.com/archives/libvir-list/2019-December/msg00086.html">https://www.redhat.com/archives/libvir-list/2019-December/msg00086.html</a><br>
</div>
<div><br>
</div>
<div>I also have a patch off libvirt-4.5 which I have tested on our HW. If needed, I can send that patch as well.</div>
<div><br>
</div>
<div>Ani</div>
<div><br>
</div>
</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">
On Dec 2, 2019, 5:22 PM +0530, Daniel P. Berrangé <berrange@redhat.com>, wrote:<br>
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
On Wed, Nov 27, 2019 at 11:10:21AM +0000, Ani Sinha wrote:<br>
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;">
Hi :<br>
<br>
I see a commit in qemu that adds support for CLZERO but in CPUIDs. :<br>
<br>
commit e900135dcfb676a4019dc206395e02db5d1de0d6<br>
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de><br>
Date: Wed Sep 25 23:49:48 2019 +0200<br>
<br>
i386: Add CPUID bit for CLZERO and XSAVEERPTR<br>
<br>
The CPUID bits CLZERO and XSAVEERPTR are availble on AMD's ZEN platform<br>
and could be passed to the guest.<br>
<br>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de><br>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com><br>
<br>
Is there a corresponding change in libvirt adding this capability? Libvirt complains when I add it manually in the vm xml:<br>
<br>
# virsh create newvm.xml<br>
error: Failed to create domain from newvm.xml<br>
error: unsupported configuration: unknown CPU feature: clzero<br>
<br>
# grep clzero newvm.xml<br>
<feature policy='require' name='clzero'/><br>
<br>
Should we add it?<br>
</blockquote>
<br>
Yes, if it is supported by QEMU to expose to a guest, then it should be<br>
added to libvirt too.<br>
<br>
Presumably only needs add an addition to src/cpu_maps/x86_features.xml<br>
<br>
Regards,<br>
Daniel<br>
--<br>
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__berrange.com&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=HIAImXOwBBjDjbozqHZOBn1uaSs-AU3LugXqoQrrLko&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__www.flickr.com_photos_dberrange&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=6zWQAT7zkr1fFfhCvnSAN6tLwYa1vFb0m66XYH46Vgw&e=
:|<br>
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__libvirt.org&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=mSj1Kh5NlO-NiBTedJkvXyreeEvNDLcEAkxVV8TxUmY&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__fstop138.berrange.com&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=mw-XirgI1BWzbKo6zZTTY_SMrUw0aD1j6CiHYAhTVJw&e=
:|<br>
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__entangle-2Dphoto.org&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=gDp9hO9xGy4cPvntUrsFe_9iiycTQSeX7II4_RzQeA0&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__www.instagram.com_dberrange&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=_vzLCn26_4Iv36BEhb8Et71nUZIB6-m6JTa97ffbqMM&e=
:|<br>
<br>
</blockquote>
<div></div>
</div>
</body>
</html>