<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 5, 2019 at 6:31 PM Andrea Bolognani <<a href="mailto:abologna@redhat.com" target="_blank">abologna@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 2019-11-11 at 09:58 +0800, Han Han wrote:<br>
> +      <change><br>
> +        <summary><br>
> +          qemu: Support kvm-hint-dedicated performance hint<br>
> +        </summary><br>
> +        <description><br>
> +          With <code>&lt;hint-dedicated state=&apos;on&apos;/&gt;</code> and<br>
> +          <code>&lt;cpu mode=&apos;host-passthrough&apos;/&gt;</code>, it<br>
<br>
No need to use "&apos;", a simple "'" will work just fine.<br>
<br>
> +          allows a guest to enable optimizations when running on dedicated<br>
> +          vCPUs. Qemu over <code>2.12</code> and kernel over <code>4.17</code><br>
<br>
s/Qemu/QEMU/<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
and the minimum version is 2.12.1 according to cb12c59dac04.<br>
<br></blockquote><div>Feature introduced version in commit msg cb12c59dac04 of   is not correct here. <br></div><div>Check that in qemu code, for the commit be7773268d target-i386: add KVM_HINTS_DEDICATED performance hint</div><div># git tag --contains=be7773268d|sort -n |head -n2<br>s<br>v2.12.0</div><div><br></div><div>So the minimum version is v2.12.0 not v2.12.1</div><div><br></div><div>Fix it at <a href="https://www.redhat.com/archives/libvir-list/2019-December/msg00319.html">https://www.redhat.com/archives/libvir-list/2019-December/msg00319.html</a></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
With the nits mentioned above addressed,<br>
<br>
  Reviewed-by: Andrea Bolognani <<a href="mailto:abologna@redhat.com" target="_blank">abologna@redhat.com</a>><br>
<br>
-- <br>
Andrea Bolognani / Red Hat / Virtualization<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div>