<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 7, 2020 at 9:35 AM Christian Ehrhardt <<a href="mailto:christian.ehrhardt@canonical.com">christian.ehrhardt@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 6, 2020 at 11:25 AM Jiri Denemark <<a href="mailto:jdenemar@redhat.com" target="_blank">jdenemar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">See the last patch for detailed description and<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1795651" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1795651</a> for a discussion<br>
about this topic.<br>
<br>
Jiri Denemark (3):<br>
qemu: Pass machine type to virQEMUCapsIsCPUModeSupported<br>
qemuxml2*test: Add default CPU tests for s390-ccw-virtio-2.7 machines<br>
qemu_capabilities: Disable CPU models on old s390 machine types<br></blockquote><div><br></div>Reviewed-by: Christian Ehrhardt <<a href="mailto:christian.ehrhardt@canonical.com" target="_blank">christian.ehrhardt@canonical.com</a>></div><div class="gmail_quote"><br></div><div class="gmail_quote">I have also set up a build with the changes adding some Ubuntu machine types on top.</div><div class="gmail_quote">I eventually also want to give you a Tested-by, but those tests not be completed this week - I beg your pardon for the delay.</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><br></div></div></blockquote><div><br></div>Tests:<br>- start old common type s390-ccw-virtio-2.5<br>- start old ubunut type s390-ccw-virtio-xenial<br>- migrate from old installation that was pre 2.8<br><br>Comparing:<br>a) libvirt 6.0 (6.0.0-0ubuntu2)<br>b) libvirt 6.0 + this series (6.0.0-0ubuntu3~test1)<br><br>a) failed in all cases with the expected<br> qemu-system-s390x: CPU models are not available: KVM doesn't support CPU models<br>b) all three cases worked fine now<br><br>Special case:<br>If I tried to start the formerly defined "breakme" domains they got added<br> <cpu mode='host-model' check='partial'/><br>Therefore they now fail with:<br> error: Failed to start domain breakme<br> error: unsupported configuration: CPU mode 'host-model' for s390x kvm domain on s390x host is not supported by hypervisor<br><br>If I undefine, and define again fromt the template as reported in the BZ<br> <domain type='kvm'><br> <name>breakme</name><br> <memory unit='KiB'>524288</memory><br> <os><br> <type arch='s390x' machine='s390-ccw-virtio-2.5'>hvm</type><br> </os><br> </domain><br>I now get after define:<br> <cpu mode='host-passthrough' check='none'/><br>So it detected things correctly detecting the old type.<br><br>A cross check using a new type like s390-ccw-virtio-4.0 or s390-ccw-virtio-eoan worked fine and gave me the epxected<br> <cpu mode='host-model' check='partial'/><br><br>Tested-by: Christian Ehrhardt <<a href="mailto:christian.ehrhardt@canonical.com">christian.ehrhardt@canonical.com</a>><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
src/qemu/qemu_capabilities.c | 29 ++++++++++++++---<br>
src/qemu/qemu_capabilities.h | 3 +-<br>
src/qemu/qemu_domain.c | 3 +-<br>
src/qemu/qemu_process.c | 2 +-<br>
...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 32 +++++++++++++++++++<br>
.../s390-default-cpu-kvm-ccw-virtio-2.7.xml | 16 ++++++++++<br>
...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 32 +++++++++++++++++++<br>
.../s390-default-cpu-tcg-ccw-virtio-2.7.xml | 16 ++++++++++<br>
tests/qemuxml2argvtest.c | 2 ++<br>
...lt-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml | 24 ++++++++++++++<br>
...lt-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml | 26 +++++++++++++++<br>
tests/qemuxml2xmltest.c | 2 ++<br>
12 files changed, 180 insertions(+), 7 deletions(-)<br>
create mode 100644 tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.args<br>
create mode 100644 tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-2.7.xml<br>
create mode 100644 tests/qemuxml2argvdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.args<br>
create mode 100644 tests/qemuxml2argvdata/s390-default-cpu-tcg-ccw-virtio-2.7.xml<br>
create mode 100644 tests/qemuxml2xmloutdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml<br>
create mode 100644 tests/qemuxml2xmloutdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml<br>
<br>
-- <br>
2.25.0<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">Christian Ehrhardt<br>Staff Engineer, Ubuntu Server<br>Canonical Ltd</div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Christian Ehrhardt<br>Staff Engineer, Ubuntu Server<br>Canonical Ltd</div></div>