<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 18, 2020 at 11:13 AM Jiri Denemark <<a href="mailto:jdenemar@redhat.com">jdenemar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Christian Ehrhardt (1):<br> cpu_map: Add more -noTSX x86 CPU models<br> <br> Jiri Denemark (3):<br> cpu_map: Add <decode> element to x86 CPU model definitions<br> cpu_x86: Honor CPU models' <decode> element<br> cpu_map: Don't use new noTSX models for host-model CPUs<br> <br></blockquote><div><br></div><div>Hi,</div><div>for the Ubuntu bug that got all of this started I applied your patches, built in a PPA and tested the case.</div><div><br>#1 virsh capabilities<br>Before:<br>Broadwell-noTSX-IBRS + 33 features<br><br>After:<br>Skylake-Client-noTSX-IBRS +24 features<br><br>=> good<br><br><br><br>#2 virsh domcapabilities<br>Before:<br>Skylake-Client-IBRS + 16 features<br><br>After:<br>Skylake-Client-IBRS + 16 features (unchanged as intended for compatibility)<br><br>=> good</div><div><br></div><div><br></div><div><br>#3 usable models<br>Before:<br>only older types<br><br>After:<br>now added "Skylake-Client-noTSX-IBRS" which is a more modern IBRS type than the others I had<br><br>=> good</div><div><br></div><div><br></div><div>#4 use the new types</div><div><br>My system isn't new enough to get the others added, but that is fine as a test.<br>Also the type "Skylake-Server-noTSX-IBRS" worked, auto-disabling the avx features my chip is missing.<br><br>I started a guest with such a type through libvirt and it looks as expected:<br> -cpu Skylake-Client-noTSX-IBRS <br><br><div>=> good</div><div></div><div><br></div>#5 and finally the adapted tests still ran fien at build time.<br></div><div><br></div><div>Thank you Jiri for the changes, please feel free to add my:</div><div><br></div><div><span style="font-family:monospace"><span style="color:rgb(0,0,0)">Reviewed-by: Christian </span><span style="font-weight:bold;color:rgb(255,84,84)">Ehrha</span><span style="color:rgb(0,0,0)">rdt <<a href="mailto:christian.ehrhardt@canonical.com">christian.ehrhardt@canonical.com</a>> </span><br>Tested-by: Christian <span style="font-weight:bold;color:rgb(255,84,84)">Ehrha</span><span style="color:rgb(0,0,0)">rdt <<a href="mailto:christian.ehrhardt@canonical.com">christian.ehrhardt@canonical.com</a>></span><br></span></div><div><span style="font-family:monospace"><span style="color:rgb(0,0,0)"><br></span></span></div><div><span style="font-family:monospace"><span style="color:rgb(0,0,0)"><br></span></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> src/cpu/cpu_x86.c | 65 ++++++++++++-<br> src/cpu_map/<a href="http://Makefile.inc.am" rel="noreferrer" target="_blank">Makefile.inc.am</a> | 5 +<br> src/cpu_map/index.xml | 5 +<br> src/cpu_map/x86_486.xml | 1 +<br> src/cpu_map/x86_Broadwell-IBRS.xml | 1 +<br> src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 1 +<br> src/cpu_map/x86_Broadwell-noTSX.xml | 1 +<br> src/cpu_map/x86_Broadwell.xml | 1 +<br> src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 79 ++++++++++++++++<br> src/cpu_map/x86_Cascadelake-Server.xml | 1 +<br> src/cpu_map/x86_Conroe.xml | 1 +<br> src/cpu_map/x86_Dhyana.xml | 1 +<br> src/cpu_map/x86_EPYC-IBPB.xml | 1 +<br> src/cpu_map/x86_EPYC.xml | 1 +<br> src/cpu_map/x86_Haswell-IBRS.xml | 1 +<br> src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 1 +<br> src/cpu_map/x86_Haswell-noTSX.xml | 1 +<br> src/cpu_map/x86_Haswell.xml | 1 +<br> src/cpu_map/x86_Icelake-Client-noTSX.xml | 82 +++++++++++++++++<br> src/cpu_map/x86_Icelake-Client.xml | 1 +<br> src/cpu_map/x86_Icelake-Server-noTSX.xml | 91 +++++++++++++++++++<br> src/cpu_map/x86_Icelake-Server.xml | 1 +<br> src/cpu_map/x86_IvyBridge-IBRS.xml | 1 +<br> src/cpu_map/x86_IvyBridge.xml | 1 +<br> src/cpu_map/x86_Nehalem-IBRS.xml | 1 +<br> src/cpu_map/x86_Nehalem.xml | 1 +<br> src/cpu_map/x86_Opteron_G1.xml | 1 +<br> src/cpu_map/x86_Opteron_G2.xml | 1 +<br> src/cpu_map/x86_Opteron_G3.xml | 1 +<br> src/cpu_map/x86_Opteron_G4.xml | 1 +<br> src/cpu_map/x86_Opteron_G5.xml | 1 +<br> src/cpu_map/x86_Penryn.xml | 1 +<br> src/cpu_map/x86_SandyBridge-IBRS.xml | 1 +<br> src/cpu_map/x86_SandyBridge.xml | 1 +<br> src/cpu_map/x86_Skylake-Client-IBRS.xml | 1 +<br> src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml | 74 +++++++++++++++<br> src/cpu_map/x86_Skylake-Client.xml | 1 +<br> src/cpu_map/x86_Skylake-Server-IBRS.xml | 1 +<br> src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml | 76 ++++++++++++++++<br> src/cpu_map/x86_Skylake-Server.xml | 1 +<br> src/cpu_map/x86_Westmere-IBRS.xml | 1 +<br> src/cpu_map/x86_Westmere.xml | 1 +<br> src/cpu_map/x86_athlon.xml | 1 +<br> src/cpu_map/x86_core2duo.xml | 1 +<br> src/cpu_map/x86_coreduo.xml | 1 +<br> src/cpu_map/x86_cpu64-rhel5.xml | 1 +<br> src/cpu_map/x86_cpu64-rhel6.xml | 1 +<br> src/cpu_map/x86_kvm32.xml | 1 +<br> src/cpu_map/x86_kvm64.xml | 1 +<br> src/cpu_map/x86_n270.xml | 1 +<br> src/cpu_map/x86_pentium.xml | 1 +<br> src/cpu_map/x86_pentium2.xml | 1 +<br> src/cpu_map/x86_pentium3.xml | 1 +<br> src/cpu_map/x86_pentiumpro.xml | 1 +<br> src/cpu_map/x86_phenom.xml | 1 +<br> src/cpu_map/x86_qemu32.xml | 1 +<br> src/cpu_map/x86_qemu64.xml | 1 +<br> .../x86_64-cpuid-Core-i7-8550U-host.xml | 11 +--<br> .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 5 +<br> .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 5 +<br> tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 5 +<br> .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 5 +<br> .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 5 +<br> tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 5 +<br> 64 files changed, 552 insertions(+), 15 deletions(-)<br> create mode 100644 src/cpu_map/x86_Cascadelake-Server-noTSX.xml<br> create mode 100644 src/cpu_map/x86_Icelake-Client-noTSX.xml<br> create mode 100644 src/cpu_map/x86_Icelake-Server-noTSX.xml<br> create mode 100644 src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml<br> create mode 100644 src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml<br> <br> -- <br> 2.25.1<br> <br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Christian Ehrhardt<br>Staff Engineer, Ubuntu Server<br>Canonical Ltd</div></div>