<div dir="ltr">Thanks for the info, as for ARM testing, we are happy to provide some machines if the community likes.<div> </div><div>BR,</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 9, 2020 at 8:03 PM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Apr 09, 2020 at 07:52:27PM +0800, Zhenyu Zheng wrote: > Hi, > > Thanks alot for all the reviews, I'm updating the codes, as for those > headers, > hwcap.h is here: > <a href="https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h" rel="noreferrer" target="_blank">https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h</a> and > should be available for 5.6, > auxv.h is from glibc: > <a href="https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/sys/auxv.h;h=1a563e1337e64e4218c1613b68dc2551a762ba00;hb=HEAD" rel="noreferrer" target="_blank">https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/sys/auxv.h;h=1a563e1337e64e4218c1613b68dc2551a762ba00;hb=HEAD</a> The key requirement from libvirt is that code must compile against our declared set of supported platforms <a href="https://libvirt.org/platforms.html" rel="noreferrer" target="_blank">https://libvirt.org/platforms.html</a> Usually RHEL-7 is the oldest platform that causes trouble. If code can't be made to compile on old platforms, then it is acceptable to use conditional compilation to disable the code. If you want to validate your patches build on all our required platforms, you can take advantage of our recent switch to GitLab Fork the libvirt repo: <a href="https://gitlab.com/libvirt/libvirt" rel="noreferrer" target="_blank">https://gitlab.com/libvirt/libvirt</a> and push your patches to a branch in your personal fork. This will trigger our automated build CI jobs across all important platforms. As an example here's a recent CI job run: <a href="https://gitlab.com/libvirt/libvirt/pipelines/134381772" rel="noreferrer" target="_blank">https://gitlab.com/libvirt/libvirt/pipelines/134381772</a> Note, however, that most of the jobs are using x86, so if you have any conditionally compiled arm code, we don't have good coverage for arm on the old distros, so that may benefit from manual testing. > > virCPUarmGetHost and the helpers it calls are architecture specific and > > should not be even compiled in on non-ARM. > > yeah, understandable, I just don't see other archs like ppc and s390 doing > this so I didn't do it. Regards, Daniel -- |: <a href="https://berrange.com" rel="noreferrer" target="_blank">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange" rel="noreferrer" target="_blank">https://www.flickr.com/photos/dberrange</a> :| |: <a href="https://libvirt.org" rel="noreferrer" target="_blank">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com" rel="noreferrer" target="_blank">https://fstop138.berrange.com</a> :| |: <a href="https://entangle-photo.org" rel="noreferrer" target="_blank">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange" rel="noreferrer" target="_blank">https://www.instagram.com/dberrange</a> :| </blockquote></div>