<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 9:12 PM Jason Dillaman <<a href="mailto:jdillama@redhat.com">jdillama@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, Apr 8, 2020 at 5:06 AM Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>><br>
---<br>
docs/<a href="http://formatdomain.html.in" rel="noreferrer" target="_blank">formatdomain.html.in</a> | 5 +++++<br>
docs/schemas/domaincommon.rng | 3 +++<br>
2 files changed, 8 insertions(+)<br>
<br>
diff --git a/docs/<a href="http://formatdomain.html.in" rel="noreferrer" target="_blank">formatdomain.html.in</a> b/docs/<a href="http://formatdomain.html.in" rel="noreferrer" target="_blank">formatdomain.html.in</a><br>
index d56600dc..06e1a7ee 100644<br>
--- a/docs/<a href="http://formatdomain.html.in" rel="noreferrer" target="_blank">formatdomain.html.in</a><br>
+++ b/docs/<a href="http://formatdomain.html.in" rel="noreferrer" target="_blank">formatdomain.html.in</a><br>
@@ -3118,6 +3118,11 @@<br>
(<span class="since">Since 6.2.0</span>)<br>
</p><br>
<br>
+ <p>For protocol <code>rbd</code>, an optional attribute<br>
+ <code>namespace</code> specifies the namespace of a rbd pool.<br>
+ (<span class="since">Since 6.3.0 and QEMU 5.0.0</span>)<br>
+ </p><br>
+<br>
<p>For "iscsi" (<span class="since">since 1.0.4</span>), the<br>
<code>name</code> attribute may include a logical unit number,<br>
separated from the target's name by a slash (e.g.,<br>
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng<br>
index dcf2e09d..294ade34 100644<br>
--- a/docs/schemas/domaincommon.rng<br>
+++ b/docs/schemas/domaincommon.rng<br>
@@ -1762,6 +1762,9 @@<br>
<optional><br>
<attribute name="name"/><br>
</optional><br>
+ <optional><br>
+ <attribute name="namespace"/><br>
+ </optional><br></blockquote><div><br></div><div>My only concern about this patchset is how the "name" attribute is overloaded (historically) to include both the RBD pool and image name. Now if the RBD namespace is separated out to its own optional attribute, it requires constructing an invalid "<pool>/<image-name>" name attribute. Can the pool be separated out to its own attribute as well (i.e. <source ... image="image1" pool="rbd" namespace="ns1"...>) and keep a deprecated backwards </div></div></div></blockquote><div>Yeah. I also noticed the historical problem of "name". It looks OK to separate the pool and image out of the name.</div><div>Let's make namespace independent first. Then split the name and keep backwards compatibility.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>compatible "name='pool/image'" attribute that doesn't support namespaces? The QAPI already has the pool and image as separate attributes. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<zeroOrMore><br>
<ref name="diskSourceNetworkHost"/><br>
</zeroOrMore><br>
-- <br>
2.25.0<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div>Jason</div></div></div></div></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div>