<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 21, 2020 at 5:21 PM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, May 21, 2020 at 04:05:47PM +0800, Han Han wrote:<br>
> On Thu, May 21, 2020 at 2:44 PM Peter Krempa <<a href="mailto:pkrempa@redhat.com" target="_blank">pkrempa@redhat.com</a>> wrote:<br>
> <br>
> > On Thu, May 21, 2020 at 14:08:17 +0800, Han Han wrote:<br>
> > > Let's drop tftp support since it is ususabled before or after QEMU v2.8<br>
> > > [1].<br>
> > ><br>
> > > [1]: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1372143" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1372143</a><br>
> > ><br>
> > ><br>
> > > Han Han (3):<br>
> > > docs: Remove tftp protocol support from docs<br>
> > > src: Remove tftp network storage support<br>
> > > news: Remove support for tftp storage protocol<br>
> ><br>
> > NACK series:<br>
> ><br>
> > 1) qemu 2.8 is still supported by libvirt<br>
> ><br>
> However, the tftp is actually unusable for all versions of qemu, while the<br>
> formatdomain doc<br>
> states that it is optional protocol<br>
<br>
Do you have any more information on this. I'd be surprised if it was<br>
/always/ unusuable, as opposed to initially working and then getting<br>
broken in some particular version of QEMU.<br></blockquote><div>I tested on qemu-kvm-1.5.3-174.el7.x86_64 curl-7.29.0-58.el7.x86_64 tftp-server-5.2-22.el7.x86_64, it doesn't work, either:</div><div>➜ ~ curl tftp://<a href="http://127.0.0.1/img" target="_blank">127.0.0.1/img</a> -o /tmp/tftp <br> % Total % Received % Xferd Average Speed Time Time Time Current<br> Dload Upload Total Spent Left Speed<br>100 100M 100 100M 0 0 20.6M 0 0:00:04 0:00:04 --:--:-- 20.6M<br>100 100M 100 100M 0 0 20.6M 0 0:00:04 0:00:04 --:--:-- 20.6M<br>➜ ~ qemu-img create -f qcow2 -b 'json:{"file.driver":"tftp", "file.url":"tftp://<a href="http://127.0.0.1/img" target="_blank">127.0.0.1/img</a>"}' /var/lib/libvirt/images/tftp.img<br>Formatting '/var/lib/libvirt/images/tftp.img', fmt=qcow2 size=104857600 backing_file='json:{"file.driver":"tftp", "file.url":"tftp://<a href="http://127.0.0.1/img" target="_blank">127.0.0.1/img</a>"}' encryption=off cluster_size=65536 lazy_refcounts=off <br></div><div>^C</div><div><br></div><div>➜ ~ qemu-img info 'json:{"file.driver":"tftp", "file.url":"tftp://<a href="http://127.0.0.1/img" target="_blank">127.0.0.1/img</a>"}'<br></div><div>^C</div><div><br></div><div>The qemu-img command above is stuck and never returns.</div><div><br></div><div>Max, is the tftp unusable for all versions of QEMU? Could you please give more info on that?<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> <br>
> > 2) we can't remove XML parser support for previously supported XMLs as<br>
> > the existing defined VMs would vanish. That's exactly why the check in<br>
> > my patch was added into the validator which doesn't validate existing<br>
> > defined configs.<br>
> ><br>
> I understand the consideration of the compatibility. How about only<br>
> removing it from docs?<br>
<br>
Regards,<br>
Daniel<br>
-- <br>
|: <a href="https://berrange.com" rel="noreferrer" target="_blank">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange" rel="noreferrer" target="_blank">https://www.flickr.com/photos/dberrange</a> :|<br>
|: <a href="https://libvirt.org" rel="noreferrer" target="_blank">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com" rel="noreferrer" target="_blank">https://fstop138.berrange.com</a> :|<br>
|: <a href="https://entangle-photo.org" rel="noreferrer" target="_blank">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange" rel="noreferrer" target="_blank">https://www.instagram.com/dberrange</a> :|<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Best regards,</div><div dir="ltr">-----------------------------------<br></div><div dir="ltr">Han Han<br>Quality Engineer<br>Redhat.<br><br>Email: <a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a><br>Phone: +861065339333<br></div></div></div></div></div></div></div>