<html style="direction: ltr;">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style id="bidiui-paragraph-margins" type="text/css">body p { margin-bottom: 0cm; margin-top: 0pt; } </style>
</head>
<body bidimailui-charset-is-forced="true" style="direction: ltr;">
<p>Signed-off-by Daniel Letai <a class="moz-txt-link-abbreviated" href="mailto:dani@letai.org.il">dani@letai.org.il</a><br>
</p>
<div class="moz-cite-prefix">On 13/10/2020 13:14:49, Daniel P.
Berrangé wrote:<br>
</div>
<blockquote type="cite" cite="mid:20201013101449.GI70612@redhat.com">
<pre class="moz-quote-pre" wrap="">On Tue, Oct 13, 2020 at 11:03:28AM +0100, Daniel P. Berrangé wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Sat, Oct 10, 2020 at 06:11:53PM +0300, Daniel Letai wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> Hi,
Attached see simple patch to remove rpath during meson build, so rpmbuild
on redhat/fedora based distros don't complain.
Seeing as all rpaths are in standard locations, this seems safe to me.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
This was supposed to have been fixed by
commit 69980ab798e240923ef12f86a92665b6c9ff7292
Author: Andrea Bolognani <a class="moz-txt-link-rfc2396E" href="mailto:abologna@redhat.com"><abologna@redhat.com></a>
Date: Wed Aug 19 11:15:35 2020 +0200
however that overlooked that %meson macro adds --auto-features=enabled,
which caused the rpath to be force enabled in the RPM build.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">>From 6622771b2f595b293e8872a44bfceb7f2097e4a5 Mon Sep 17 00:00:00 2001
From: Daniel Letai <a class="moz-txt-link-rfc2396E" href="mailto:dani@letai.org.il"><dani@letai.org.il></a>
Date: Sat, 10 Oct 2020 18:02:13 +0300
Subject: [PATCH] Remove rpath from rpms
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index edf919d7ba..7e356bb843 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1184,6 +1184,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec)
-Dinit_script=systemd \
-Ddocs=enabled \
-Dtests=enabled \
+ -Drpath=disabled \
%{?arg_login_shell}
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
so yeah, we need this.
Reviewed-by: Daniel P. Berrangé <a class="moz-txt-link-rfc2396E" href="mailto:berrange@redhat.com"><berrange@redhat.com></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
BTW, we require contributions to be signed-off, to assert that the
author is in compliance with the Developer Certificate of Origin
<a class="moz-txt-link-freetext" href="https://developercertificate.org/">https://developercertificate.org/</a>
Assuming you're fine with this, just reply to this mail with a
Signed-Off-By line that has your name+email addr
Regards,
Daniel
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Regards,
Daniel Letai
+972 (0)505 870 456</pre>
</body>
</html>