<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink="#954F72" style='word-wrap:break-word'><div class=WordSection1>I also realized this is already fixed.<o:p></o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p>Thank you<o:p></o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p>发送自 Windows 10 版<a href="https://go.microsoft.com/fwlink/?LinkId=550986">邮件</a>应用<o:p> </o:p><div style='mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'>发件人: <a href="mailto:pkrempa@redhat.com">Peter Krempa</a> 发送时间: 2021年1月4日 21:15 收件人: <a href="mailto:274268859@qq.com">liyalei</a> 抄送: <a href="mailto:libvir-list@redhat.com">libvir-list@redhat.com</a>; <a href="mailto:liyl43@chinatelecom.cn">liyalei</a> 主题: Re: [PATCH] Fix wrong use of path variable</div><o:p> </o:p>On Wed, Dec 30, 2020 at 18:39:35 +0800, liyalei wrote:> From: liyalei <liyl43@chinatelecom.cn><o:p> </o:p>Please provide some more description in the commit message, such asdescribe the bug that this patch is fixing.<o:p> </o:p>Additionally the libvirt project requires [1] you to certify that youare in compliance of the 'Developer certificate of origin' [2] byproviding the appropriate tag in the commit message (read the docs tofigure out which).<o:p> </o:p>[1]: https://libvirt.org/hacking.html#developer-certificate-of-origin[2]: https://developercertificate.org/<o:p> </o:p>> > ---> src/util/virnetdevopenvswitch.c | 2 +-> 1 file changed, 1 insertion(+), 1 deletion(-)> > diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c> index d380b0cf22..7eabaa763d 100644> --- a/src/util/virnetdevopenvswitch.c> +++ b/src/util/virnetdevopenvswitch.c> @@ -494,7 +494,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path,> if (server) {> virCommandAddArgList(cmd, "--no-headings", "--columns=name", "find",> "Interface", NULL);> - virCommandAddArgPair(cmd, "options:vhost-server-path", "path");> + virCommandAddArgPair(cmd, "options:vhost-server-path", path);<o:p> </o:p>Looks like this is already fixed:<o:p> </o:p>commit 0dd029b7f2e7d9619ca6a22f43857aafb449c3a7Author: Michal PrÃvoznÃk <mprivozn@redhat.com>Date: Wed Dec 16 18:52:48 2020 +0100<o:p> </o:p> virNetDevOpenvswitchGetVhostuserIfname: Actually use @path to lookup interface<o:p> </o:p> In v6.10.0-rc1~221 I wanted to make virNetDevOpenvswitchGetVhostuserIfname() lookup interface name even for vhostuser interfaces with mode='server'. For these, we are given a socket path which is then created by QEMU and to which OpenVSwitch connects to and creates an interface. Because of this, we don't know the name of the interface upfront (when starting QEMU) and have to use the path to query OpenVSwitch later (using ovs-vsctl). What I intended to use was:<o:p> </o:p> ovs-vsctl --no-headings --columns=name find Interface options:vhost-server-path=$path<o:p> </o:p> But what my code does is:<o:p> </o:p> ovs-vsctl --no-headings --columns=name find Interface options:vhost-server-path=path<o:p> </o:p> and it's all because the argument to the function is named "path" which I then enclosed in double quotes while it should have been used as a variable.<o:p> </o:p> Fixes: e4c29e2904197472919d050c67acfd59f0144bbc Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1767013 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Laine Stump <laine@redhat.com><o:p> </o:p>diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.cindex d380b0cf22..7eabaa763d 100644--- a/src/util/virnetdevopenvswitch.c+++ b/src/util/virnetdevopenvswitch.c@@ -494,7 +494,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, if (server) { virCommandAddArgList(cmd, "--no-headings", "--columns=name", "find", "Interface", NULL);- virCommandAddArgPair(cmd, "options:vhost-server-path", "path");+ virCommandAddArgPair(cmd, "options:vhost-server-path", path); } else { const char *tmpIfname = NULL;<o:p> </o:p><o:p> </o:p>> } else {> const char *tmpIfname = NULL;> > -- > 2.27.0> <o:p> </o:p><o:p> </o:p></div></body></html>