<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr"><div class="gmail_default" style="font-size:large">Sigh.. One more issue with the patch series. I sent a tiny patch for formal approval.</div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">Nikolay</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 7, 2021 at 3:00 PM Michal Privoznik <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/7/21 12:53 PM, John Ferlan wrote:<br>
> <br>
> <br>
> On 12/18/20 1:56 AM, Nikolay Shirokovskiy wrote:<br>
>> Otherwise in some places we can mistakenly report 'unsupported' error instead<br>
>> of root cause. So let's handle root cause explicitly from the macro.<br>
>><br>
>> Signed-off-by: Nikolay Shirokovskiy <<a href="mailto:nshirokovskiy@virtuozzo.com" target="_blank">nshirokovskiy@virtuozzo.com</a>><br>
>> ---<br>
>>   src/libvirt-domain.c | 511 ++++++++++++++++++++++++++++++++++-----------------<br>
>>   src/libvirt-host.c   |  18 +-<br>
>>   src/libvirt.c        |   7 +-<br>
>>   3 files changed, 365 insertions(+), 171 deletions(-)<br>
>><br>
> <br>
> [...]<br>
> <br>
>> @@ -3005,8 +3019,11 @@ virDomainMigrateVersion3Full(virDomainPtr domain,<br>
>>           return NULL;<br>
>>       params = tmp;<br>
>>   <br>
>> -    if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,<br>
>> -                                 VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION))<br>
>> +    ret = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,<br>
>> +                                   VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION);<br>
>> +    if (ret < 0)<br>
>> +        return NULL;<br>
>> +    if (ret)<br>
> <br>
> Coverity complains this is a RESOURCE_LEAK for @tmp (or essentially @params)<br>
> <br>
> Perhaps the hunk for VIR_DRV_SUPPORTS_FEATURE should go before<br>
> virTypedParamsCopy or use goto done (similar if !dom_xml)?<br>
> <br>
<br>
Yes, reorder looks good.<br>
<br>
Michal<br>
<br>
</blockquote></div>