<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 26, 2021 at 6:07 PM Paolo Bonzini <<a href="mailto:pbonzini@redhat.com">pbonzini@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 26/01/21 04:55, Han Han wrote:<br>
> Since the commit ccd3b3b811 of QEMU, the short-form boolean options in <br>
> qemu cmdline like "server", "nowait", "disable-ticketing" are <br>
> deprecated<br>
<br>
There are a few more:<br>
<br></blockquote><div>Thank you for mentioning the missing parameters :) <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
1) -vnc password, -vnc tls, -vnc sasl:<br>
<br>
     if (graphics->data.vnc.auth.passwd || cfg->vncPassword)<br>
         virBufferAddLit(&opt, ",password");<br>
<br>
     if (cfg->vncTLS) {<br>
         qemuDomainGraphicsPrivatePtr gfxPriv = <br>
QEMU_DOMAIN_GRAPHICS_PRIVATE(graphics);<br>
         if (gfxPriv->tlsAlias) {<br>
...<br>
         } else {<br>
             virBufferAddLit(&opt, ",tls");<br>
             ...<br>
         }<br>
     }<br>
<br>
     if (cfg->vncSASL) {<br>
         virBufferAddLit(&opt, ",sasl");<br>
<br>
         if (cfg->vncSASLdir)<br>
             virCommandAddEnvPair(cmd, "SASL_CONF_PATH", cfg->vncSASLdir);<br>
<br>
         /* TODO: Support ACLs later */<br>
     }<br>
<br>
"-vnc tls" is only used for old QEMU, but I think it's cleaner to change <br>
it as well.<br>
<br>
2) -chardev telnet<br>
<br>
         virBufferAsprintf(&buf,<br>
                           "socket,id=%s,host=%s,port=%s%s",<br>
                           charAlias,<br>
                           dev->data.tcp.host,<br>
                           dev->data.tcp.service,<br>
                           telnet ? ",telnet" : "");<br>
<br>
3) -fsdev readonly:<br>
<br>
     if (fs->readonly)<br>
         virBufferAddLit(&opt, ",readonly");<br>
<br>
4) -spice sasl:<br>
<br>
     if (cfg->spiceSASL) {<br>
         virBufferAddLit(&opt, "sasl,");<br>
<br>
         if (cfg->spiceSASLdir)<br>
             virCommandAddEnvPair(cmd, "SASL_CONF_PATH",<br>
                                  cfg->spiceSASLdir);<br>
<br>
         /* TODO: Support ACLs later */<br>
     }<br>
<br>
5) qemu-img create:<br>
<br>
     if (info->features && info->format == VIR_STORAGE_FILE_QCOW2) {<br>
         if (virBitmapIsBitSet(info->features,<br>
                               VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS)) {<br>
             if (STREQ_NULLABLE(info->compat, "0.10")) {<br>
                 virReportError(VIR_ERR_CONFIG_UNSUPPORTED,<br>
                                _("lazy_refcounts not supported with compat"<br>
                                  " level %s"),<br>
                                info->compat);<br>
                 return -1;<br>
             }<br>
             virBufferAddLit(&buf, "lazy_refcounts,");<br>
         }<br>
     }<br>
<br>
> diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c<br>
> index 2d1f5ea5f5..97954bcc37 100644<br>
> --- a/src/libxl/xen_common.c<br>
> +++ b/src/libxl/xen_common.c<br>
> @@ -872,7 +872,7 @@ xenParseSxprChar(const char *value,<br>
>          else<br>
>              def->source->data.tcp.service = g_strdup(offset);<br>
>  <br>
> -        if (offset2 && strstr(offset2, ",server"))<br>
> +        if (offset2 && strstr(offset2, ",server=on"))<br>
>              def->source->data.tcp.listen = true;<br>
>      }<br>
>      break;<br>
> @@ -924,7 +924,7 @@ xenParseSxprChar(const char *value,<br>
>              def->source->data.nix.path = g_strdup(value);<br>
>  <br>
>          if (offset != NULL &&<br>
> -            strstr(offset, ",server") != NULL)<br>
> +            strstr(offset, ",server=on") != NULL)<br>
>              def->source->data.nix.listen = true;<br>
>      }<br>
>      break;<br>
<br>
As far as I understand it, it is valid to start a domain with "xl" and <br>
inspect it with "virsh dumpxml".  So I wouldn't change this, as it <br>
depends on whatever xl has placed in the value you are parsing.<br>
<br>
Thanks,<br>
<br>
Paolo<br>
<br>
</blockquote></div></div>